Bugzilla – Attachment 67319 Details for
Bug 18999
Acq: Shipping cost not included in total spent on acq home and funds page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18999 - Followup based on tester feedback
Bug-18999---Followup-based-on-tester-feedback.patch (text/plain), 1.36 KB, created by
Josef Moravec
on 2017-09-22 16:06:57 UTC
(
hide
)
Description:
Bug 18999 - Followup based on tester feedback
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-09-22 16:06:57 UTC
Size:
1.36 KB
patch
obsolete
>From 8c7726b9b13b301c13313706af5955fe160ed8ed Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Sat, 16 Sep 2017 07:52:25 +0000 >Subject: [PATCH] Bug 18999 - Followup based on tester feedback > >Removed unneccessary declaration of $budget and changed >Koha::Acquisition::Order->new->insert into >Koha::Acquisition::Order->new->store as requested in tester feedback > >Test plan: >1. Go into your koha-shell > >2. set the PERL5LIB variable > >3. Run t/db_dependent/Budgets.t > >All tests should pass > >Sponsored-by: Catalyst IT > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/Budgets.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Budgets.t b/t/db_dependent/Budgets.t >index 08f30ae..d3ccec4 100755 >--- a/t/db_dependent/Budgets.t >+++ b/t/db_dependent/Budgets.t >@@ -398,7 +398,7 @@ is( GetBudgetHierarchySpent( $budget_id111 ), 20, "total spent for budget111 is > my $budget_period_amount = 100; > my $budget_amount = 50; > >-my $budget = AddBudgetPeriod( >+$budget = AddBudgetPeriod( > { > budget_period_startdate => '2017-08-22', > budget_period_enddate => '2018-08-22', >@@ -460,7 +460,7 @@ my $order = Koha::Acquisition::Order->new( > discount => 0, > uncertainprice => 0, > } >-)->insert; >+)->store; > > ModReceiveOrder({ > bibionumber => $biblio, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18999
:
65446
|
65626
|
66378
|
66855
|
67173
|
67316
|
67317
|
67318
|
67319
|
67471
|
67472
|
67473
|
67474