Attachment 6735 Details for Bug 7325 – Bug 7325 - Editing a list generates errors in the log

[patch] Bug 7325 - Editing a list generates errors in the log

Bug-7325---Editing-a-list-generates-errors-in-the-.patch (text/plain), 1.29 KB, created by Chris Cormack on 2011-12-13 08:11:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-12-13 08:11:54 UTC

Size: 1.29 KB

patch

obsolete

>From 8a1d98f3f967fd82db3a883e7806a8376e2701c7 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 6 Dec 2011 16:03:31 -0500
>Subject: [PATCH] Bug 7325 - Editing a list generates errors in the log
>
>Checking for variables before trying to use them in
>building the pagination menu
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> C4/VirtualShelves/Page.pm |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm
>index 18535a5..523527e 100644
>--- a/C4/VirtualShelves/Page.pm
>+++ b/C4/VirtualShelves/Page.pm
>@@ -367,9 +367,9 @@ sub shelfpage ($$$$$) {
>         $qhash{$_} = $query->param($_) if $query->param($_);
>     }
>     ( scalar keys %qhash ) and $url .= '?' . join '&', map { "$_=$qhash{$_}" } keys %qhash;
>-    if ( $shelfnumber ) {
>+    if ( $shelfnumber && $totitems ) {
>         $template->param(  pagination_bar => pagination_bar( $url, ( int( $totitems / $shelflimit ) ) + ( ( $totitems % $shelflimit ) > 0 ? 1 : 0 ), $itemoff, "itemoff" )  );
>-    } else {
>+    } elsif ( $totshelves ) {
>         $template->param(
>              pagination_bar => pagination_bar( $url, ( int( $totshelves / $shelveslimit ) ) + ( ( $totshelves % $shelveslimit ) > 0 ? 1 : 0 ), $shelfoff, "shelfoff" )  );
>     }
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7325: 6615 | 6735