Bugzilla – Attachment 67370 Details for
Bug 19367
$biblio variable redefined in same scope in ISBDdetail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19367 - $biblio variable redefined in same scope in ISBDdetail
Bug-19367---biblio-variable-redefined-in-same-scop.patch (text/plain), 1.48 KB, created by
Jonathan Druart
on 2017-09-26 17:26:37 UTC
(
hide
)
Description:
Bug 19367 - $biblio variable redefined in same scope in ISBDdetail
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-09-26 17:26:37 UTC
Size:
1.48 KB
patch
obsolete
>From 400fddb9e85e3e1d2a088c9834871be04388688c Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 26 Sep 2017 11:45:25 +1000 >Subject: [PATCH] Bug 19367 - $biblio variable redefined in same scope in > ISBDdetail > >The following warning is generated by ISBDdetail.pl: >my" variable $biblio masks earlier declaration in same scope >at ./catalogue/ISBDdetail.pl line 171. > >This patch removes this unnecessary declaration, which removes the >warning. > >_TEST PLAN_ > >After applying patch: > >1) Check code compilation with "KOHA_CONF=/path/to/koha-conf.xml perl -c catalogue/ISBDdetail.pl" >2) Note the only message is "./catalogue/ISBDdetail.pl syntax OK" >2) On /cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=1, >view the source of the page and verify that the Javascript >contains a holdcount e.g. "var holdcount = 0". > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > catalogue/ISBDdetail.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/catalogue/ISBDdetail.pl b/catalogue/ISBDdetail.pl >index f58e1a9091..27cb699026 100755 >--- a/catalogue/ISBDdetail.pl >+++ b/catalogue/ISBDdetail.pl >@@ -170,7 +170,6 @@ $template->param (countorders => $count_orders_using_biblio); > my $count_deletedorders_using_biblio = scalar @deletedorders_using_biblio ; > $template->param (countdeletedorders => $count_deletedorders_using_biblio); > >-my $biblio = Koha::Biblios->find( $biblionumber ); > my $holds = $biblio->holds; > $template->param( holdcount => $holds->count ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19367
:
67356
|
67370
|
67780