Attachment 6739 Details for Bug 7326 – Bug 7326: longoverdue.pl hardcoded to 366 days maximum

[patch] Bug 7326: longoverdue.pl hardcoded to 366 days maximum

Bug-7326-longoverduepl-hardcoded-to-366-days-maxim.patch (text/plain), 1.89 KB, created by Chris Cormack on 2011-12-13 08:36:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-12-13 08:36:21 UTC

Size: 1.89 KB

patch

obsolete

>From 42db5679540188a6bb27c0885a189287b3ef63df Mon Sep 17 00:00:00 2001
>From: Ian Walls <ian.walls@bywatersolutions.com>
>Date: Tue, 6 Dec 2011 19:12:04 -0500
>Subject: [PATCH] Bug 7326: longoverdue.pl hardcoded to 366 days maximum
>
>Adds --maxdays command line flag to longoverdue.pl to allow the user to specify
>their own $endrange value.  Because sometimes 366 isn't enough!
>
>Also adds help documentation for both --quiet and --maxdays params
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>
>Simple change, works well
>---
> misc/cronjobs/longoverdue.pl |    8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>diff --git a/misc/cronjobs/longoverdue.pl b/misc/cronjobs/longoverdue.pl
>index 3843544..e3648d5 100755
>--- a/misc/cronjobs/longoverdue.pl
>+++ b/misc/cronjobs/longoverdue.pl
>@@ -39,7 +39,7 @@ use Getopt::Long;
> 
> my  $lost;  #  key=lost value,  value=num days.
> my ($charge, $verbose, $confirm, $quiet);
>-my $endrange = 366;  # FIXME hardcoded - don't deal with anything overdue by more than this num days.
>+my $endrange = 366;
> 
> GetOptions( 
>     'lost=s%'    => \$lost,
>@@ -47,6 +47,7 @@ GetOptions(
>     'confirm'    => \$confirm,
>     'verbose'    => \$verbose,
>     'quiet'      => \$quiet,
>+    'maxdays=s'  => \$endrange
> );
> 
> my $usage = << 'ENDUSAGE';
>@@ -68,6 +69,11 @@ This script takes the following parameters :
>     --confirm           confirm.  without this option, the script will report the number of affected items and
>                         return without modifying any records.
> 
>+    --quiet             suppress summary output.
>+
>+    --maxdays           Specifies the end of the range of overdue days to deal with (defaults to 366).  This
>+                        value is universal to all lost num days overdue passed.
>+
>   examples :
>   $PERL5LIB/misc/cronjobs/longoverdue.pl --lost 30=1
>     Would set LOST=1 after 30 days (up to one year), but not charge the account.
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7326: 6630 | 6739