Bugzilla – Attachment 67410 Details for
Bug 19116
Holds not set to waiting when "Confirm" is used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19116: (followup) Add tests to highlight the problem in CheckReserves
Bug-19116-followup-Add-tests-to-highlight-the-prob.patch (text/plain), 1.59 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-09-27 18:23:50 UTC
(
hide
)
Description:
Bug 19116: (followup) Add tests to highlight the problem in CheckReserves
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-09-27 18:23:50 UTC
Size:
1.59 KB
patch
obsolete
>From b66a774a3aa60cad0a5429831ad8ec23fcb235d3 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 22 Sep 2017 08:40:56 +0000 >Subject: [PATCH] Bug 19116: (followup) Add tests to highlight the problem in > CheckReserves > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Circulation.t | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 90859ad..28521e8 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -1730,7 +1730,7 @@ subtest 'AddReturn | is_overdue' => sub { > }; > > subtest 'Set waiting flag' => sub { >- plan tests => 2; >+ plan tests => 4; > > my $library_1 = $builder->build( { source => 'Branch' } ); > my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode} } } ); >@@ -1768,12 +1768,17 @@ subtest 'Set waiting flag' => sub { > my $hold = Koha::Holds->find( $reserve_id ); > is( $hold->found, 'T', 'Hold is in transit' ); > >+ my ( $status ) = CheckReserves($item->{itemnumber}); >+ is( $status, 'Reserved', 'Hold is not waiting yet'); >+ > set_userenv( $library_2 ); > $do_transfer = 0; > AddReturn( $item->{barcode}, $library_2->{branchcode} ); > ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id ); > $hold = Koha::Holds->find( $reserve_id ); > is( $hold->found, 'W', 'Hold is waiting' ); >+ ( $status ) = CheckReserves($item->{itemnumber}); >+ is( $status, 'Waiting', 'Now the hold is waiting'); > }; > > sub set_userenv { >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19116
:
66307
|
66511
|
66824
|
66947
|
67079
|
67080
|
67306
|
67307
|
67308
|
67309
|
67310
|
67409
| 67410 |
67411