Bugzilla – Attachment 67411 Details for
Bug 19116
Holds not set to waiting when "Confirm" is used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19116: Hold not set to waiting after transfer
Bug-19116-Hold-not-set-to-waiting-after-transfer.patch (text/plain), 1.77 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-09-27 18:24:00 UTC
(
hide
)
Description:
Bug 19116: Hold not set to waiting after transfer
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-09-27 18:24:00 UTC
Size:
1.77 KB
patch
obsolete
>From 323c64b5584d2996826734f9e565230c7ec733c3 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 22 Aug 2017 08:58:11 +0000 >Subject: [PATCH] Bug 19116: Hold not set to waiting after transfer > >Test plan: > >0) Do not apply the patch >1) Place hold on item from another branch >2) Switch to that branch >3) Check them in at the other branch to set them into transport status (T) >4) Switch back to your homebranch >5) Check items in again, use the different confirm buttons and > compare: Only "confirm and print" will be set to waiting, "confirm" > remains in transport. >6) Apply the patch >7) Repeat 1-5 - now should work as expected - the hold is marked waiting >on "confirm" button too >8) Check the hold from the same branch, to make sure this doesn't add >regression > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Reserves.pm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 521b072..fbf03fb 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -732,7 +732,11 @@ sub CheckReserves { > my $priority = 10000000; > foreach my $res (@reserves) { > if ( $res->{'itemnumber'} == $itemnumber && $res->{'priority'} == 0) { >- return ( "Waiting", $res, \@reserves ); # Found it >+ if ($res->{'found'} eq 'W') { >+ return ( "Waiting", $res, \@reserves ); # Found it, it is waiting >+ } else { >+ return ( "Reserved", $res, \@reserves ); # Found determinated hold, e. g. the tranferred one >+ } > } else { > my $patron; > my $iteminfo; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19116
:
66307
|
66511
|
66824
|
66947
|
67079
|
67080
|
67306
|
67307
|
67308
|
67309
|
67310
|
67409
|
67410
| 67411