Attachment 67475 Details for Bug 19388 – Bug 19388: FIX display item status if item is checked out

[patch] Bug 19388: FIX display item status if item is checked out

Bug-19388-FIX-display-item-status-if-item-is-check.patch (text/plain), 2.05 KB, created by Jonathan Druart on 2017-09-29 14:52:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-09-29 14:52:53 UTC

Size: 2.05 KB

patch

obsolete

>From 70d5f07786ffc3f873fc18ee955e63034aca480f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 29 Sep 2017 11:49:30 -0300
>Subject: [PATCH] Bug 19388: FIX display item status if item is checked out
>
>In course reserves, if an item which was added to a course is checked
>out, it is not possible to show details for that course on OPAC.
>The error says: "Template process failed: undef error - The method
>onsite_checkout is not covered by tests! at
>/home/koha/src/C4/Templates.pm line 121."
>
>onsite_checkout is an attribute of Koha::Checkout, not Koha::Item
>
>Test plan:
>Create a course with 2 items that are checked out (standard and on-site)
>At the OPAC, add them to your cart and confirm the status of these 2
>items is correct
>Confirm that on the detail page of the bib record as well as the detail
>of the course.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
>index 408de462ee..ffb4d52965 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
>@@ -16,12 +16,16 @@
>     [% END %]
> [% END %]
> 
>-[% IF item.isa('Koha::Item') %][% SET datedue = issue.date_due %]
>-[% ELSE %][% SET datedue = item.datedue || issue.date_due %]
>+[% IF item.isa('Koha::Item') %]
>+    [% SET datedue = issue.date_due %]
>+    [% SET onsite_checkout = issue.onsite_checkout %]
>+[% ELSE %]
>+    [% SET datedue = item.datedue || issue.date_due %]
>+    [% SET onsite_checkout = item.onsite_checkout %]
> [% END %]
> [% IF datedue %]
>     [% SET itemavailable = 0 %]
>-    [% IF item.onsite_checkout %]
>+    [% IF onsite_checkout %]
>         [% IF ( OPACShowCheckoutName ) %]
>             <span class="item-status checkedout">Currently in local use by [% item.firstname %] [% item.surname %] [% IF ( item.cardnumber ) %]([% item.cardnumber %])[% END %]</span>
>         [% ELSE %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19388: 67475 | 67485 | 67676