Bugzilla – Attachment 67482 Details for
Bug 19259
Overdue rules do not save (delay field should only accept numbers)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19259: Enforce type of the delay value when editing overdue rules - template side only
Bug-19259-Enforce-type-of-the-delay-value-when-edi.patch (text/plain), 1.62 KB, created by
David Bourgault
on 2017-09-29 18:18:27 UTC
(
hide
)
Description:
Bug 19259: Enforce type of the delay value when editing overdue rules - template side only
Filename:
MIME Type:
Creator:
David Bourgault
Created:
2017-09-29 18:18:27 UTC
Size:
1.62 KB
patch
obsolete
>From b449feae342bc1f407ca2314c0fe05792ebef6e5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 27 Sep 2017 13:07:59 -0300 >Subject: [PATCH] Bug 19259: Enforce type of the delay value when editing > overdue rules - template side only > >Overdue rules do not save when a delay that is not an integer > 0, >without any warnings. >This patch forces the user to select a number > 0. > >Test plan: >Without this patch applied, enter non-integer value or negative or 0 >=> The rule will not be inserted without any warnings. >With this patch applied you will get an message from the browser and the >form will not save > >Signed-off-by: David Bourgault <david.bourgault@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >index c780f30..bb6e824 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >@@ -112,7 +112,7 @@ $(document).ready(function() { > <tr> > <th scope="row">[% value.line %]</th> > <td> >- <input type="text" name="delay[% tab.number %]-[% value.overduename %]" size="5" value="[% value.delay %]" /> >+ <input type="number" min="1" name="delay[% tab.number %]-[% value.overduename %]" value="[% value.delay %]" /> > </td> > <td> > <select name="letter[% tab.number %]-[% value.overduename %]"> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19259
:
67400
|
67482
|
67921