Bugzilla – Attachment 67534 Details for
Bug 19389
Don't offer search option for libary groups when no groups are defined
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19389: Hide library groups pull down if empty
Bug-19389-Hide-library-groups-pull-down-if-empty.patch (text/plain), 1.74 KB, created by
Katrin Fischer
on 2017-10-02 23:17:10 UTC
(
hide
)
Description:
Bug 19389: Hide library groups pull down if empty
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-10-02 23:17:10 UTC
Size:
1.74 KB
patch
obsolete
>From f185bafbc8bb53b4340dd72cea5dd27d2b66140c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 2 Oct 2017 14:30:14 -0300 >Subject: [PATCH] Bug 19389: Hide library groups pull down if empty > >Regression introduced by bug > commit 141200794da9f27e0231e1c2dad4bcb994d650f3 > Bug 15295: Koha::Libraries - Remove GetBranchCategories > >The intranet advanced search page offers to search for groups of >libraries, even if the pull down is empty as no library groups have >been defined. > >Test plan: >- Go to the adv search page at the intranet >- Without library group you must not see the "Groups of libraries" >dropdown list >- With at least a library group you must see it > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >index 8425f59..ee2c189 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >@@ -242,7 +242,7 @@ > [% PROCESS options_for_libraries libraries => Branches.all( selected => selected_branchcode, unfiltered => 1 ) %] > </select></p> > <!-- <input type="hidden" name="limit" value="branch: MAIN" /> --> >- [% IF ( searchdomainloop ) %] >+ [% IF searchdomainloop.count %] > <p>OR</p> <!-- should addjs to grey out group pulldown if a library is selected. --> > <p><label for="categoryloop">Groups of libraries: </label><select name="multibranchlimit" id="categoryloop"> > <option value=""> -- none -- </option> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19389
:
67528
|
67534
|
68687