Attachment 67540 Details for Bug 18897 – Bug 18897: Add skipping to t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t

[patch] Bug 18897: Add skipping to t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t

Bug-18897-Add-skipping-to-tdbdependentKohaSearchEn.patch (text/plain), 1.71 KB, created by Mark Tompsett on 2017-10-03 02:10:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2017-10-03 02:10:14 UTC

Size: 1.71 KB

patch

obsolete

>From a6783bc9f157e8971ded870977aab42c2545c420 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Mon, 2 Oct 2017 22:00:57 -0400
>Subject: [PATCH] Bug 18897: Add skipping to
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
>
>Test Plan:
>$ git fetch
>$ git checkout -b bug_18897 origin/master
>$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
>$ prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
>-- nasty failure.
>$ git bz apply 18897
>-- apply all the patches
>$ prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
>-- nicer skip message
>run the koha qa test tools
>---
> t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t b/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
>index 5c37200..5a6b86d 100644
>--- a/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
>+++ b/t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
>@@ -17,9 +17,24 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 12;
>+use Module::Load::Conditional qw[can_load check_install requires];
>+use Test::More;
> use t::lib::Mocks;
> 
>+if ( ! can_load(
>+    modules => { 'Koha::SearchEngine::Elasticsearch::Indexer' => undef, } )
>+) {
>+    my $missing_module;
>+    if ( $Module::Load::Conditional::ERROR =~ /Can\'t locate (.*?) / ) {
>+        $missing_module = $1;
>+    }
>+    my $es_dep_msg = "Required module $missing_module is not installed";
>+    plan( skip_all => $es_dep_msg );
>+}
>+else {
>+    plan tests => 12;
>+}
>+
> use Koha::SearchEngine::Elasticsearch::QueryBuilder;
> 
> my $builder = Koha::SearchEngine::Elasticsearch::QueryBuilder->new( { index => 'mydb' } );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18897: 64818 | 66478 | 66479 | 66568 | 66569 | 66777 | 66779 | 67521 | 67522 | 67523 | 67539 | 67540 | 67553 | 67554 | 67555 | 67556 | 67557