Attachment 67567 Details for Bug 19198 – Bug 19198 - Unit tests

[patch] Bug 19198 - Unit tests

Bug-19198---Unit-tests.patch (text/plain), 3.55 KB, created by Nick Clemens (kidclamp) on 2017-10-03 17:44:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-10-03 17:44:06 UTC

Size: 3.55 KB

patch

obsolete

>From 89042059b8f0e09ef4d763bed9541477e3ef93df Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 29 Aug 2017 14:10:54 +0000
>Subject: [PATCH] Bug 19198 - Unit tests
>
>Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
>---
> t/db_dependent/Circulation.t | 59 +++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 56 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 720018c..4205d99 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 102;
>+use Test::More tests => 103;
> 
> use DateTime;
> 
>@@ -1783,6 +1783,7 @@ subtest 'Set waiting flag' => sub {
> 
>     my $biblio = $builder->build( { source => 'Biblio' } );
>     my $biblioitem = $builder->build( { source => 'Biblioitem', value => { biblionumber => $biblio->{biblionumber} } } );
>+
>     my $item = $builder->build(
>         {
>             source => 'Item',
>@@ -1797,8 +1798,6 @@ subtest 'Set waiting flag' => sub {
>         }
>     );
> 
>-
>-
>     set_userenv( $library_2 );
>     my $reserve_id = AddReserve(
>         $library_2->{branchcode}, $patron_2->{borrowernumber}, $biblioitem->{biblionumber},
>@@ -1825,6 +1824,60 @@ subtest 'Set waiting flag' => sub {
>     is( $status, 'Waiting', 'Now the hold is waiting');
> };
> 
>+subtest 'AddReturn | is_overdue' => sub {
>+    plan tests => 3;
>+
>+# Set a simple circ policy
>+$dbh->do('DELETE FROM issuingrules');
>+$dbh->do(
>+    q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
>+                                maxissueqty, issuelength, lengthunit,
>+                                renewalsallowed, renewalperiod,
>+                                norenewalbefore, auto_renew,
>+                                fine, chargeperiod)
>+      VALUES (?, ?, ?, ?,
>+              ?, ?, ?,
>+              ?, ?,
>+              ?, ?,
>+              ?, ?
>+             )
>+    },
>+    {},
>+    '*', '*', '*', 25,
>+    1, 14, 'days',
>+    1, 7,
>+    undef, 0,
>+    .10, 1
>+);
>+    my $five_days_go = output_pref({ dt => dt_from_string->add( days => 5 ), dateonly => 1});
>+    my $ten_days_go  = output_pref({ dt => dt_from_string->add( days => 10), dateonly => 1 });
>+    my $library = $builder->build( { source => 'Branch' } );
>+    my $patron  = $builder->build( { source => 'Borrower' } );
>+
>+    my $biblioitem = $builder->build( { source => 'Biblioitem' } );
>+    my $item = $builder->build(
>+        {
>+            source => 'Item',
>+            value  => {
>+                homebranch    => $library->{branchcode},
>+                holdingbranch => $library->{branchcode},
>+                notforloan    => 0,
>+                itemlost      => 0,
>+                withdrawn     => 0,
>+                biblionumber  => $biblioitem->{biblionumber},
>+            }
>+        }
>+    );
>+
>+    my $issue = AddIssue( $patron, $item->{barcode}, $five_days_go ); # date due was 10d ago
>+    my $actualissue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
>+    is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
>+    my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->{barcode},$ten_days_go, undef, undef, undef);
>+    is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
>+    is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
>+
>+};
>+
> sub set_userenv {
>     my ( $library ) = @_;
>     C4::Context->set_userenv(0,0,0,'firstname','surname', $library->{branchcode}, $library->{branchname}, '', '', '');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19198: 66584 | 66585 | 66670 | 66671 | 67111 | 67112 | 67113 | 67567 | 67568 | 67569 | 67571 | 67572 | 67573 | 67719 | 67720