Attachment 67573 Details for Bug 19198 – Bug 19198: (QA followup) Fix typo in conditions

[patch] Bug 19198: (QA followup) Fix typo in conditions

Bug-19198-QA-followup-Fix-typo-in-conditions.patch (text/plain), 1.09 KB, created by Tomás Cohen Arazi (tcohen) on 2017-10-03 18:34:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-10-03 18:34:28 UTC

Size: 1.09 KB

patch

obsolete

>From bde2b1b85654616f514e6204087ed2bbce5482d9 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 13 Sep 2017 11:59:19 +0000
>Subject: [PATCH] Bug 19198: (QA followup) Fix typo in conditions
>
>'&' should be '&&'
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index a9345b8..6ba87a2 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -893,7 +893,7 @@ sub CanBookBeIssued {
>       and $issue->borrowernumber == $borrower->{'borrowernumber'} ? 1 : 0 );
>     my $toomany = TooMany( $borrower, $item->{biblionumber}, $item, { onsite_checkout => $onsite_checkout, switch_onsite_checkout => $switch_onsite_checkout, } );
>     # if TooMany max_allowed returns 0 the user doesn't have permission to check out this book
>-    if ( $toomany  & !$needsconfirmation{RENEW_ISSUE} ) {
>+    if ( $toomany && !$needsconfirmation{RENEW_ISSUE} ) {
>         if ( $toomany->{max_allowed} == 0 ) {
>             $needsconfirmation{PATRON_CANT} = 1;
>         }
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 19198: 66584 | 66585 | 66670 | 66671 | 67111 | 67112 | 67113 | 67567 | 67568 | 67569 | 67571 | 67572 | 67573 | 67719 | 67720