Attachment 67576 Details for Bug 19370 – Bug 19370: Remove undefined variable warning

[patch] Bug 19370: Remove undefined variable warning

Bug-19370-Remove-undefined-variable-warning.patch (text/plain), 1.21 KB, created by Tomás Cohen Arazi (tcohen) on 2017-10-03 20:05:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-10-03 20:05:58 UTC

Size: 1.21 KB

patch

obsolete

>From f0efe9e124d0b33f66eef364867fa751b168063a Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 3 Oct 2017 17:03:54 -0300
>Subject: [PATCH] Bug 19370: Remove undefined variable warning
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/REST/Plugin/Query.pm | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/REST/Plugin/Query.pm b/Koha/REST/Plugin/Query.pm
>index 32656a4..45cfe14 100644
>--- a/Koha/REST/Plugin/Query.pm
>+++ b/Koha/REST/Plugin/Query.pm
>@@ -79,11 +79,12 @@ Generates the DBIC order_by attributes based on I<$params>, and merges into I<$a
>             my ( $c, $args ) = @_;
>             my $attributes = $args->{attributes};
> 
>-            my @order_by =
>-              map { _build_order_atom($_) }
>-              split( /\|/, $args->{params}->{_order_by} );
>+            if ( defined $args->{params}->{_order_by} ) {
>+                my @order_by = map { _build_order_atom($_) }
>+                                split( /\|/, $args->{params}->{_order_by} );
>+                $attributes->{order_by} = \@order_by;
>+            }
> 
>-            $attributes->{order_by} = \@order_by;
>             return $attributes;
>         }
>     );
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 19370: 67379 | 67380 | 67402 | 67403 | 67525 | 67576 | 67782 | 67783 | 67784 | 69304 | 69305 | 69307 | 69383 | 69384 | 69391 | 69392 | 69393 | 69394