Bugzilla – Attachment 67584 Details for
Bug 4319
waiting and in transit items cannot be reserved
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 4319 - [OPAC] allow to holds waiting items
Bug-4319---OPAC-allow-to-holds-waiting-items.patch (text/plain), 2.68 KB, created by
Alex Buckley
on 2017-10-04 03:30:12 UTC
(
hide
)
Description:
Bug 4319 - [OPAC] allow to holds waiting items
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-10-04 03:30:12 UTC
Size:
2.68 KB
patch
obsolete
>From 4b5be2fcfbf329b72057baf745e8ce3996768bae Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Tue, 3 Oct 2017 14:50:36 +0000 >Subject: [PATCH] Bug 4319 - [OPAC] allow to holds waiting items > >Test plan: > > - Checkout an item > - Place hold on this item, > - Return the item > - Make sure the hold is waiting (found W) and AllowOnShelfHolds is > not to 'Allow' > - Check that the button "Place hold" appears in opac detail page of > the biblio > >Followed test plan (see below note), patch worked as described. Also ran QA test tool and >both altered files passed. > >Just a note about the test plan: AllowOnShelfHolds is no longer a syspref, but it exists in >the circulation matrix, i.e. it is available on the Administrator->Circulation and >fine rules, to test this patch I set it to 'If any unavailable'. > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >--- > .../opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- > opac/opac-detail.pl | 10 ++++++---- > 2 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >index 5e96b0f..9069ee4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >@@ -3,7 +3,7 @@ > [% UNLESS ( norequests ) %] > [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] > [% IF Koha.Preference( 'RequestOnOpac' ) == 1 %] >- [% IF ( AllowOnShelfHolds OR ItemsIssued ) %] >+ [% IF ( AllowOnShelfHolds OR ItemsIssued OR ItemsWaiting ) %] > <li><a class="reserve" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% biblionumber | html %]">Place hold</a></li> > [% END %] > [% END %] >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 8252e50..858e952 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -458,10 +458,12 @@ if ($session->param('busc')) { > } > } > >- >-$template->param( 'ItemsIssued' => CountItemsIssued( $biblionumber ) ); >-$template->param('OPACShowCheckoutName' => C4::Context->preference("OPACShowCheckoutName") ); >-$template->param('OPACShowBarcode' => C4::Context->preference("OPACShowBarcode") ); >+$template->param( >+ ItemsIssued => CountItemsIssued( $biblionumber ), >+ ItemsWaiting => Koha::Holds->search({biblionumber => $biblionumber, found => 'W'})->count(), >+ OPACShowCheckoutName => C4::Context->preference("OPACShowCheckoutName"), >+ OPACShowBarcode => C4::Context->preference("OPACShowBarcode") >+); > > # adding items linked via host biblios > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4319
:
3740
|
4099
|
4110
|
4327
|
4329
|
16965
|
67558
|
67584
|
67637
|
67704
|
67970
|
68194
|
68197
|
68198
|
68199
|
68531
|
68782
|
68786
|
69724
|
69725
|
69728
|
69815
|
69816
|
69817
|
70457