Attachment 67677 Details for Bug 19260 – Bug 19260: Add test for CancelExpiredReserves

[patch] Bug 19260: Add test for CancelExpiredReserves

Bug-19260-Add-test-for-CancelExpiredReserves.patch (text/plain), 2.95 KB, created by Marcel de Rooy on 2017-10-06 09:16:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-10-06 09:16:58 UTC

Size: 2.95 KB

patch

obsolete

>From 05a9d735de420fe9ab20cb1e81fe333dc6fb5e5d Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Thu, 5 Oct 2017 20:36:31 +0000
>Subject: [PATCH] Bug 19260: Add test for CancelExpiredReserves
>Content-Type: text/plain; charset=utf-8
>
>Passes QA test tool
>Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Reserves.t | 63 ++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 62 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index fd79427..1e3f1c0 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 58;
>+use Test::More tests => 59;
> use Test::MockModule;
> use Test::Warn;
> 
>@@ -692,6 +692,67 @@ subtest '_koha_notify_reserve() tests' => sub {
> 
> };
> 
>+subtest 'CancelExpiredReserves tests' => sub {
>+    plan tests => 2;
>+
>+    $dbh->do('DELETE FROM reserves');
>+
>+    my $category = $builder->build({ source => 'Category' });
>+    my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode };
>+
>+    my $borrowernumber = AddMember(
>+        firstname =>  'my firstname',
>+        surname => 'my surname',
>+        categorycode => $category->{categorycode},
>+        branchcode => $branchcode,
>+    );
>+
>+    my $resdate = dt_from_string->add( days => -20 );
>+    my $expdate = dt_from_string->add( days => -2 );
>+    my $notexpdate = dt_from_string->add( days => 2 );
>+
>+    my $hold1 = Koha::Hold->new({
>+        branchcode => $branchcode,
>+        borrowernumber => $borrowernumber,
>+        biblionumber => $bibnum,
>+        priority => 1,
>+        reservedate => $resdate,
>+        expirationdate => $notexpdate,
>+        found => undef
>+    })->store;
>+
>+    my $hold2 = Koha::Hold->new({
>+        branchcode => $branchcode,
>+        borrowernumber => $borrowernumber,
>+        biblionumber => $bibnum,
>+        priority => 2,
>+        reservedate => $resdate,
>+        expirationdate => $expdate,
>+        found => undef
>+    })->store;
>+
>+    my $hold3 = Koha::Hold->new({
>+        branchcode => $branchcode,
>+        borrowernumber => $borrowernumber,
>+        biblionumber => $bibnum,
>+        itemnumber => $itemnumber,
>+        priority => 0,
>+        reservedate => $resdate,
>+        expirationdate => $expdate,
>+        found => 'W'
>+    })->store;
>+
>+    t::lib::Mocks::mock_preference( 'ExpireReservesMaxPickUpDelay', 0 );
>+    CancelExpiredReserves();
>+    my $count1 = Koha::Holds->search->count;
>+    is( $count1, 2, 'Only the non-waiting expired holds should be cancelled');
>+
>+    t::lib::Mocks::mock_preference( 'ExpireReservesMaxPickUpDelay', 1 );
>+    CancelExpiredReserves();
>+    my $count2 = Koha::Holds->search->count;
>+    is( $count2, 1, 'Also the waiting expired hold should be cancelled now');
>+};
>+
> sub count_hold_print_messages {
>     my $message_count = $dbh->selectall_arrayref(q{
>         SELECT COUNT(*)
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19260: 67428 | 67489 | 67653 | 67654 | 67659 | 67660 | 67677 | 67678 | 67679 | 67680 | 67733 | 67992 | 67993 | 67994 | 67995