Bugzilla – Attachment 67734 Details for
Bug 18606
Move rotating collections code to Koha::Object
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18606: Add RotationCollections object classes
Bug-18606-Add-RotationCollections-object-classes.patch (text/plain), 6.95 KB, created by
Josef Moravec
on 2017-10-06 17:14:18 UTC
(
hide
)
Description:
Bug 18606: Add RotationCollections object classes
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-10-06 17:14:18 UTC
Size:
6.95 KB
patch
obsolete
>From 486a8ec72e58bddd8f74ed34a8d51594bcc53549 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 14 Oct 2016 16:38:02 +0200 >Subject: [PATCH] Bug 18606: Add RotationCollections object classes > >Test plan: >1) Apply the patch >2) Update database >3) Go to tools -> Rotating collections and play with trying to break it: > 3a) Add some collections > 3b) Edit them > 3c) Add some items to collections > 3d) Remove some items > 3e) Transfer some collections > 3f) Try to remove collection without items > 3g) Try to remove collection with items >4) Go to returns and: > 4a) Try to return item from untransferred collection > 4b) Try to return item from transferred collection >5) prove t/db_dependent/Koha/RotatingCollections.t >t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t >t/db_dependent/Circulation/Returns.t >--- > Koha/RotatingCollection.pm | 52 ++++++++++++++++++++++++++++++++ > Koha/RotatingCollection/Tracking.pm | 52 ++++++++++++++++++++++++++++++++ > Koha/RotatingCollection/Trackings.pm | 58 ++++++++++++++++++++++++++++++++++++ > Koha/RotatingCollections.pm | 58 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 220 insertions(+) > create mode 100644 Koha/RotatingCollection.pm > create mode 100644 Koha/RotatingCollection/Tracking.pm > create mode 100644 Koha/RotatingCollection/Trackings.pm > create mode 100644 Koha/RotatingCollections.pm > >diff --git a/Koha/RotatingCollection.pm b/Koha/RotatingCollection.pm >new file mode 100644 >index 0000000..c8857b2 >--- /dev/null >+++ b/Koha/RotatingCollection.pm >@@ -0,0 +1,52 @@ >+package Koha::RotatingCollection; >+ >+# Copyright Josef Moravec 2016 >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ >+use Modern::Perl; >+ >+use Carp; >+ >+use Koha::Database; >+ >+use base qw(Koha::Object); >+ >+=head1 NAME >+ >+Koha::RotatingCollection - Koha Rotating collection Object class >+ >+=head1 API >+ >+=head2 Class Methods >+ >+=cut >+ >+=head3 type >+ >+=cut >+ >+sub _type { >+ return 'Collection'; >+} >+ >+=head1 AUTHOR >+ >+Josef Moravec <josef.moravec@gmail.com> >+ >+=cut >+ >+1; >diff --git a/Koha/RotatingCollection/Tracking.pm b/Koha/RotatingCollection/Tracking.pm >new file mode 100644 >index 0000000..275e6ad >--- /dev/null >+++ b/Koha/RotatingCollection/Tracking.pm >@@ -0,0 +1,52 @@ >+package Koha::RotatingCollection::Tracking; >+ >+# Copyright Josef Moravec 2017 >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ >+use Modern::Perl; >+ >+use Carp; >+ >+use Koha::Database; >+ >+use base qw(Koha::Object); >+ >+=head1 NAME >+ >+Koha::RotatingCollection::Tracking - Koha Rotating collection tracking Object class >+ >+=head1 API >+ >+=head2 Class Methods >+ >+=cut >+ >+=head3 type >+ >+=cut >+ >+sub _type { >+ return 'CollectionsTracking'; >+} >+ >+=head1 AUTHOR >+ >+Josef Moravec <josef.moravec@gmail.com> >+ >+=cut >+ >+1; >diff --git a/Koha/RotatingCollection/Trackings.pm b/Koha/RotatingCollection/Trackings.pm >new file mode 100644 >index 0000000..0c6fe32 >--- /dev/null >+++ b/Koha/RotatingCollection/Trackings.pm >@@ -0,0 +1,58 @@ >+package Koha::RotatingCollection::Trackings; >+ >+# Copyright Josef Moravec 2017 >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ >+use Modern::Perl; >+ >+use Carp; >+ >+use Koha::Database; >+ >+use Koha::RotatingCollection::Tracking; >+ >+use base qw(Koha::Objects); >+ >+=head1 NAME >+ >+Koha::RotatingCollection::Trackings - Koha Rotating collection trackings Object set class >+ >+=head1 API >+ >+=head2 Class Methods >+ >+=cut >+ >+=head3 type >+ >+=cut >+ >+sub _type { >+ return 'CollectionsTracking'; >+} >+ >+sub object_class { >+ return 'Koha::RotatingCollection::Tracking'; >+} >+ >+=head1 AUTHOR >+ >+Josef Moravec <josef.moravec@gmail.com> >+ >+=cut >+ >+1; >diff --git a/Koha/RotatingCollections.pm b/Koha/RotatingCollections.pm >new file mode 100644 >index 0000000..255930f >--- /dev/null >+++ b/Koha/RotatingCollections.pm >@@ -0,0 +1,58 @@ >+package Koha::RotatingCollections; >+ >+# Copyright Josef Moravec 2016 >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ >+use Modern::Perl; >+ >+use Carp; >+ >+use Koha::Database; >+ >+use Koha::RotatingCollection; >+ >+use base qw(Koha::Objects); >+ >+=head1 NAME >+ >+Koha::RotatingCollections - Koha Rotating collection Object set class >+ >+=head1 API >+ >+=head2 Class Methods >+ >+=cut >+ >+=head3 type >+ >+=cut >+ >+sub _type { >+ return 'Collection'; >+} >+ >+sub object_class { >+ return 'Koha::RotatingCollection'; >+} >+ >+=head1 AUTHOR >+ >+Josef Moravec <josef.moravec@gmail.com> >+ >+=cut >+ >+1; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18606
:
63508
|
63509
|
63510
|
63511
|
63512
|
63513
|
63514
|
63515
|
63516
|
63517
|
63518
|
63519
|
63520
|
63521
|
63522
|
63523
|
63524
|
63525
|
63526
|
63527
|
63528
|
66227
|
66228
|
66229
|
66230
|
66231
|
66232
|
66233
|
66234
|
66235
|
66236
|
66237
|
66238
|
66239
|
66240
|
66241
|
66286
|
66287
|
66288
|
66289
|
66290
|
66291
|
66292
|
66293
|
66294
|
66295
|
66296
|
66297
|
66298
|
66299
|
66300
|
67734
|
67735
|
67736
|
67737
|
67738
|
67739
|
67740
|
67741
|
67742
|
67743
|
67744
|
67745
|
67746
|
67747
|
67748
|
67749
|
68428
|
68429
|
68430
|
68431
|
68432
|
68433
|
68434
|
68435
|
68436
|
68437
|
68438
|
68439
|
68440
|
68441
|
68442
|
68443
|
69709
|
69710
|
69711
|
69712
|
69713
|
69714
|
69715
|
69716
|
69717
|
69718
|
69719
|
69720
|
69721
|
69722
|
69723
|
69759
|
72416
|
72417
|
72418
|
72419
|
72420
|
72421
|
72422
|
72423
|
72424
|
72425
|
72426
|
72427
|
72428
|
72429
|
72430
|
72431
|
72572
|
72573
|
72574
|
72575
|
72576
|
72577
|
72578
|
72579
|
72580
|
72581
|
72582
|
72583
|
72584
|
72585
|
72586
|
72587
|
72816
|
79141
|
79142
|
79143
|
79144
|
79145
|
79146
|
79147
|
79148
|
79149
|
79150
|
79151
|
79152
|
79153
|
79154
|
79155
|
79156
|
79157
|
79158
|
79161