Attachment 67843 Details for Bug 15486 – Bug 15486: Unit tests

[patch] Bug 15486: Unit tests

Bug-15486-Unit-tests.patch (text/plain), 3.38 KB, created by Tomás Cohen Arazi (tcohen) on 2017-10-09 13:40:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-10-09 13:40:03 UTC

Size: 3.38 KB

patch

obsolete

>From cda7ec7034180206b978d88d7bec9043540b3872 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 19 Jul 2017 16:30:24 -0300
>Subject: [PATCH] Bug 15486: Unit tests
>
>This patch introduces unit tests for the new circulation rules option
>that allows setting a max holds per day limit.
>
>To test:
>- Apply the patch
>- Run:
>  $ sudo koha-shell kohadev
> k$ cd kohaclone
> k$ prove t/db_dependent/Holds.t
>=> FAIL: CanItemBeReserved doesn't check the amount of holds per day
>   and the introduced error code is not returned. OK is returned
>   instead.
>---
> t/db_dependent/Holds.t | 35 +++++++++++++++++++++++++++++++----
> 1 file changed, 31 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
>index cea4209..7b914df 100755
>--- a/t/db_dependent/Holds.t
>+++ b/t/db_dependent/Holds.t
>@@ -7,7 +7,7 @@ use t::lib::TestBuilder;
> 
> use C4::Context;
> 
>-use Test::More tests => 53;
>+use Test::More tests => 56;
> use MARC::Record;
> use C4::Biblio;
> use C4::Items;
>@@ -388,10 +388,10 @@ $dbh->do('DELETE FROM biblio');
>     = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $bibnum );
> 
> $dbh->do(
>-    q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
>-      VALUES (?, ?, ?, ?, ?)},
>+    q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record, holds_per_day)
>+      VALUES (?, ?, ?, ?, ?, ?)},
>     {},
>-    '*', '*', 'ONLY1', 1, 99
>+    '*', '*', 'ONLY1', 1, 99, 2
> );
> is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
>     'OK', 'Patron can reserve item with hold limit of 1, no holds placed' );
>@@ -401,6 +401,33 @@ my $res_id = AddReserve( $branch_1, $borrowernumbers[0], $bibnum, '', 1, );
> is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
>     'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
> 
>+# Add two more items
>+my ( $bibnum_2, undef, $bibitemnum_2 ) = create_helper_biblio('ONLY1');
>+my ( undef, undef, $itemnumber_2 )
>+    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $bibnum_2 );
>+my ( $bibnum_3, undef, $bibitemnum_3 ) = create_helper_biblio('ONLY1');
>+my ( undef, undef, $itemnumber_3 )
>+    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $bibnum_3 );
>+# Raise reservesallowed to avoid tooManyReserves
>+$dbh->do(q{
>+    UPDATE issuingrules SET reservesallowed=3 WHERE itemtype='ONLY1'
>+});
>+
>+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber_2 ),
>+    'OK', 'Patron can reserve item with hold limit of 1, 1 bib level hold placed, 2 reserves daily cap' );
>+
>+# Add a second reserve
>+$res_id = AddReserve( $branch_1, $borrowernumbers[0], $bibnum_2, '', 1, );
>+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber_2 ),
>+    'tooManyReservesToday', 'Patron cannot reserve item with hold limit of 3, 2 bib level hold placed on the same day, 2 reserves daily cap' );
>+
>+# Update last hold so reservedate is in the past, so 2 holds, but different day
>+$hold = Koha::Holds->find( $res_id );
>+my $yesterday = dt_from_string() - DateTime::Duration->new( days => 1 ) ;
>+$hold->reservedate( $yesterday )->store;
>+
>+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber_2 ),
>+    'OK', 'Patron can reserve item with hold limit of 3, 2 bib level hold placed on different days, 2 reserves daily cap' );
> 
> # Helper method to set up a Biblio.
> sub create_helper_biblio {
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 15486: 65128 | 65129 | 65130 | 65131 | 65132 | 65133 | 67202 | 67203 | 67204 | 67205 | 67206 | 67207 | 67337 | 67840 | 67841 | 67842 | 67843 | 67844 | 67845 | 68728 | 68729 | 68730 | 68731 | 68732 | 68733 | 68734 | 68735 | 68750 | 68751 | 68752 | 68791 | 71314 | 71315 | 71316 | 71317 | 71318 | 71319 | 72709 | 79318 | 79319 | 79320 | 79321 | 79322 | 79323 | 79324 | 79696 | 79697 | 79698 | 79699 | 79700 | 79701 | 79702 | 80478 | 80479 | 80480 | 80481 | 80482 | 80483 | 80484 | 81087