Attachment 67906 Details for Bug 15685 – Bug 15685: Add tests for Koha::Acquisition::Order->basket

[patch] Bug 15685: Add tests for Koha::Acquisition::Order->basket

Bug-15685-Add-tests-for-KohaAcquisitionOrder-baske.patch (text/plain), 2.81 KB, created by Jonathan Druart on 2017-10-10 20:48:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-10-10 20:48:27 UTC

Size: 2.81 KB

patch

obsolete

>From 8af52c07d589916c36dea1c59435a43ec5da7d71 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 5 Oct 2017 12:17:33 -0300
>Subject: [PATCH] Bug 15685: Add tests for Koha::Acquisition::Order->basket
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Acquisition/Order.pm               |  2 +-
> t/db_dependent/Koha/Acquisition/Order.t | 57 +++++++++++++++++++++++++++++++++
> 2 files changed, 58 insertions(+), 1 deletion(-)
> create mode 100644 t/db_dependent/Koha/Acquisition/Order.t
>
>diff --git a/Koha/Acquisition/Order.pm b/Koha/Acquisition/Order.pm
>index 5f7b7d940d..bbad104117 100644
>--- a/Koha/Acquisition/Order.pm
>+++ b/Koha/Acquisition/Order.pm
>@@ -109,7 +109,7 @@ Returns the basket associated to the order.
> 
> sub basket {
>     my ( $self )  = @_;
>-    return Koha::Acquisition::Baskets->find( $self->{basketno} );
>+    return Koha::Acquisition::Baskets->find( $self->basketno );
> }
> 
> =head2 Internal methods
>diff --git a/t/db_dependent/Koha/Acquisition/Order.t b/t/db_dependent/Koha/Acquisition/Order.t
>new file mode 100644
>index 0000000000..f597453f8d
>--- /dev/null
>+++ b/t/db_dependent/Koha/Acquisition/Order.t
>@@ -0,0 +1,57 @@
>+#!/usr/bin/perl
>+
>+# Copyright 2017 Koha Development team
>+#
>+# This file is part of Koha
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Test::More tests => 1;
>+
>+use t::lib::TestBuilder;
>+use t::lib::Mocks;
>+
>+use Koha::Database;
>+
>+my $schema  = Koha::Database->schema;
>+my $builder = t::lib::TestBuilder->new;
>+
>+subtest 'basket() tests' => sub {
>+
>+    plan tests => 2;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $basket = $builder->build_object(
>+        {
>+            class => 'Koha::Acquisition::Baskets'
>+        }
>+    );
>+    my $order = $builder->build_object(
>+        {
>+            class => 'Koha::Acquisition::Orders',
>+            value => { basketno => $basket->basketno }
>+        }
>+    );
>+
>+    my $retrieved_basket = $order->basket;
>+    is( ref($retrieved_basket), 'Koha::Acquisition::Basket',
>+        'Type is correct for ->basket' );
>+    is_deeply( $retrieved_basket->unblessed,
>+        $basket->unblessed, "Correct basket found and updated" );
>+
>+    $schema->storage->txn_rollback;
>+};
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 15685: 47783 | 55094 | 55096 | 57390 | 57392 | 57395 | 57424 | 57425 | 57426 | 57427 | 64918 | 64919 | 64920 | 64921 | 64922 | 65119 | 65120 | 65121 | 65122 | 65895 | 65896 | 65897 | 65898 | 65899 | 65900 | 66119 | 66120 | 66121 | 66122 | 66123 | 66124 | 67638 | 67639 | 67640 | 67641 | 67642 | 67643 | 67644 | 67645 | 67646 | 67647 | 67689 | 67690 | 67691 | 67692 | 67693 | 67694 | 67695 | 67696 | 67697 | 67698 | 67884 | 67898 | 67899 | 67900 | 67901 | 67902 | 67903 | 67904 | 67905 | 67906 | 67907 | 67908 | 67909 | 67910 | 67911