Attachment 67919 Details for Bug 16401 – Bug 16401: (follow-up) Avoid changing empty staffClientBaseURL preference

[patch] Bug 16401: (follow-up) Avoid changing empty staffClientBaseURL preference

Bug-16401-follow-up-Avoid-changing-empty-staffClie.patch (text/plain), 1.25 KB, created by Nick Clemens (kidclamp) on 2017-10-11 00:11:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-10-11 00:11:54 UTC

Size: 1.25 KB

patch

obsolete

>From b13b9f8bf090b89eccdebd6c43dd7dfdf4ca193f Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 20 Sep 2017 23:28:49 +0200
>Subject: [PATCH] Bug 16401: (follow-up) Avoid changing empty
> staffClientBaseURL preference
>
>Adds a condition to check that the staffClientBaseUrl is not empty
>before updating it with 'http://'.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> installer/data/mysql/atomicupdate/bug_16401.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_16401.perl b/installer/data/mysql/atomicupdate/bug_16401.perl
>index 946953c..3f3492e 100644
>--- a/installer/data/mysql/atomicupdate/bug_16401.perl
>+++ b/installer/data/mysql/atomicupdate/bug_16401.perl
>@@ -1,6 +1,6 @@
> $DBversion = 'XXX';  # will be replaced by the RM
> if( CheckVersion( $DBversion ) ) {
>-    $dbh->do( "UPDATE systempreferences SET value = CONCAT('http://', value) WHERE variable = 'staffClientBaseURL' AND value NOT LIKE 'http%'" );
>+    $dbh->do( "UPDATE systempreferences SET value = CONCAT('http://', value) WHERE variable = 'staffClientBaseURL' AND value <> '' AND value NOT LIKE 'http%'" );
> 
>     # Always end with this (adjust the bug info)
>     SetVersion( $DBversion );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16401: 66025 | 66143 | 66712 | 67268 | 67269 | 67270 | 67271 | 67918 | 67919 | 67967