Bugzilla – Attachment 6792 Details for
Bug 7360
Importing a SQL file for frameworks based on Default Framework deletes the default framework
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7360 Import Default framework into other deletes default Framework
SIGNED-OFF-Bug-7360-Import-Default-framework-into-.patch (text/plain), 2.22 KB, created by
Francois Charbonnier
on 2011-12-14 17:30:33 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7360 Import Default framework into other deletes default Framework
Filename:
MIME Type:
Creator:
Francois Charbonnier
Created:
2011-12-14 17:30:33 UTC
Size:
2.22 KB
patch
obsolete
>From 58d14475ed02d505be8115672d1413512c3868bc Mon Sep 17 00:00:00 2001 >From: Admin User Koha <koha@biblibre.com> >Date: Wed, 14 Dec 2011 17:31:00 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 7360 Import Default framework into other > deletes default Framework >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Step to reproduce : >- export default framework as SQL >- create new framework >- Import the exported SQL file into this new framework. >Go to default framework : >It disappeared. > >If some libraries want to share default frameworks, then it is a major bug. >This patch fixes the test in order to cope with 0 character framework name. > >Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> >--- > C4/ImportExportFramework.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm >index a2b650b..d85e64f 100755 >--- a/C4/ImportExportFramework.pm >+++ b/C4/ImportExportFramework.pm >@@ -776,7 +776,7 @@ sub _parseSQLLine > my $stmt = SQL::Statement->new($line, $parser); > my $where = $stmt->where(); > if ($where && $where->op() eq '=' && $line =~ /^\s*DELETE/) { >- $line =~ s/frameworkcode='.+?'/frameworkcode='$frameworkcode';/ unless ($_ =~ /frameworkcode='$frameworkcode'/); >+ $line =~ s/frameworkcode='.*?'/frameworkcode='$frameworkcode';/ unless ($_ =~ /frameworkcode='$frameworkcode'/); > } else { > my @arrFields; > my @arrValues; >@@ -817,7 +817,7 @@ sub _parseSQLLine > if ($error) { > $line .= ';' unless ($line =~ /;$/); > if ($line =~ /^\s*DELETE/) { >- $line =~ s/frameworkcode='.+?'/frameworkcode='$frameworkcode'/ unless ($_ =~ /frameworkcode='$frameworkcode'/); >+ $line =~ s/frameworkcode='.*?'/frameworkcode='$frameworkcode'/ unless ($_ =~ /frameworkcode='$frameworkcode'/); > } elsif ($line =~ /^\s*INSERT\s+INTO\s+(.*?)\s+\((.*?frameworkcode.*?)\)\s+VALUES\s+\((.+)\)\s*;\s*$/) { > my $table = $1; > my $fields = $2; >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7360
:
6790
| 6792