Bugzilla – Attachment 67943 Details for
Bug 14826
Store account offsets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14826: Add offset for rental fees
Bug-14826-Add-offset-for-rental-fees.patch (text/plain), 2.06 KB, created by
Kyle M Hall (khall)
on 2017-10-11 11:27:05 UTC
(
hide
)
Description:
Bug 14826: Add offset for rental fees
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-10-11 11:27:05 UTC
Size:
2.06 KB
patch
obsolete
>From 9f7ba9f22d84cb605699c45938c7dc9f9be19652 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 15 Feb 2017 16:24:57 +0000 >Subject: [PATCH] Bug 14826: Add offset for rental fees > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Circulation.pm | 38 ++++++++++++++++++++++++++------------ > 1 file changed, 26 insertions(+), 12 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 42f4428..70b2470 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -3184,19 +3184,33 @@ sub _get_discount_from_rule { > > sub AddIssuingCharge { > my ( $itemnumber, $borrowernumber, $charge ) = @_; >- my $dbh = C4::Context->dbh; >- my $nextaccntno = getnextacctno( $borrowernumber ); >- my $manager_id = 0; >+ >+ my $nextaccntno = getnextacctno($borrowernumber); >+ >+ my $manager_id = 0; > $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv; >- my $query =" >- INSERT INTO accountlines >- (borrowernumber, itemnumber, accountno, >- date, amount, description, accounttype, >- amountoutstanding, manager_id) >- VALUES (?, ?, ?,now(), ?, 'Rental', 'Rent',?,?) >- "; >- my $sth = $dbh->prepare($query); >- $sth->execute( $borrowernumber, $itemnumber, $nextaccntno, $charge, $charge, $manager_id ); >+ >+ my $accountline = Koha::Account::Line->new( >+ { >+ borrowernumber => $borrowernumber, >+ itemnumber => $itemnumber, >+ accountno => $nextaccntno, >+ amount => $charge, >+ amountoutstanding => $charge, >+ manager_id => $manager_id, >+ description => 'Rental', >+ accounttype => 'Rent', >+ date => \'NOW()', >+ } >+ )->store(); >+ >+ Koha::Account::Offset->new( >+ { >+ debit_id => $accountline->id, >+ type => 'Rental Fee', >+ amount => $charge, >+ } >+ )->store(); > } > > =head2 GetTransfers >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14826
:
53318
|
53319
|
53320
|
53321
|
53324
|
53326
|
53602
|
53603
|
53604
|
53605
|
53606
|
53607
|
59254
|
59255
|
59256
|
59257
|
59258
|
60270
|
60271
|
60272
|
60273
|
60274
|
60275
|
60276
|
60277
|
60278
|
60439
|
60440
|
60441
|
60442
|
60443
|
60444
|
60445
|
60446
|
64051
|
64052
|
64053
|
64054
|
64055
|
64056
|
64057
|
64058
|
64059
|
64217
|
64220
|
64222
|
64223
|
64224
|
64225
|
64226
|
64227
|
64228
|
65459
|
65460
|
65461
|
65462
|
65463
|
65464
|
65465
|
65466
|
65467
|
65642
|
65643
|
65644
|
65645
|
65646
|
65647
|
65648
|
65649
|
65650
|
65651
|
65652
|
66387
|
66388
|
66389
|
66390
|
66391
|
66392
|
66393
|
66394
|
66395
|
66396
|
66397
|
66716
|
67453
|
67454
|
67455
|
67456
|
67457
|
67458
|
67459
|
67460
|
67461
|
67462
|
67463
|
67464
|
67465
|
67936
|
67937
|
67938
|
67939
|
67940
|
67941
|
67942
|
67943
|
67944
|
67945
|
67946
|
67947
|
67948
|
67949
|
68018
|
68019
|
68020
|
68021
|
68022
|
68023
|
68024
|
68025
|
68026
|
68027
|
68028
|
68029
|
68030
|
68031
|
68032
|
68334
|
68383