Bugzilla – Attachment 67958 Details for
Bug 19083
'Show all details' checkbox on basket summary page is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19083: Fix 'show all details' link on closed basket detail
Bug-19083-Fix-show-all-details-link-on-closed-bask.patch (text/plain), 1.42 KB, created by
Owen Leonard
on 2017-10-11 14:01:55 UTC
(
hide
)
Description:
Bug 19083: Fix 'show all details' link on closed basket detail
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2017-10-11 14:01:55 UTC
Size:
1.42 KB
patch
obsolete
>From 4fedbe99f53aa2f48fccd9c06c49942b79e1deca Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 10 Oct 2017 10:58:24 -0300 >Subject: [PATCH] Bug 19083: Fix 'show all details' link on closed basket > detail > >'Show all details' add columns on the basket summary page. >This link is broken if the basket is closed. > >Indeed there is a JS error raised by $('#toolbar').fixFloat(); >The toolbar is not displayed if the basket is closed. > >This is caused by bug 12333, which added the floating toolbar. > >Test plan: >Create 2 baskets with orders >Close 1 basket >Click on the 'show all details' links and confirm it works as expected >Also confirm that the toolbar works correctly > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index bf37a37..6903a01 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -38,7 +38,7 @@ > } > > $(document).ready(function() { >- $('#toolbar').fixFloat(); >+ if ( $('#toolbar').length ) {$('#toolbar').fixFloat();} > $("#show_all_details").click(function(){ > updateColumnsVisibility($(this).is(":checked")); > }); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19083
:
67874
|
67958
|
67965
|
68056