Attachment 68042 Details for Bug 12768 – Bug 12768 - Fix up unit tests a bit more

[patch] Bug 12768 - Fix up unit tests a bit more

Bug-12768---Fix-up-unit-tests-a-bit-more.patch (text/plain), 1.70 KB, created by Kyle M Hall (khall) on 2017-10-12 16:57:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-10-12 16:57:14 UTC

Size: 1.70 KB

patch

obsolete

>From 09daf22d13c9d9805413a42342a4ba20e6ef67be Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 12 Oct 2017 12:44:49 -0400
>Subject: [PATCH] Bug 12768 - Fix up unit tests a bit more
>
>---
> t/db_dependent/Circulation.t | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index ef95eeb..a2dbf33 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -778,7 +778,9 @@ C4::Context->dbh->do("DELETE FROM accountlines");
>     is( $offset->type, 'Fine', 'Account offset type is Fine' );
>     is( $offset->amount, '15.000000', 'Account offset amount is 15.00' );
> 
>-    ModItem({ itype => 'BK' }, $biblionumber, $itemnumber, 1);
>+    t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
>+    t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
>+
>     LostItem( $itemnumber, 1 );
> 
>     my $item = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber);
>@@ -789,13 +791,10 @@ C4::Context->dbh->do("DELETE FROM accountlines");
>         undef, $renewing_borrower->{borrowernumber}
>     );
> 
>-    ok( $total_due == 12, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
>+    is( $total_due, '15.000000', 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
> 
>     C4::Context->dbh->do("DELETE FROM accountlines");
> 
>-    t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
>-    t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
>-
>     C4::Overdues::UpdateFine(
>         {
>             issue_id       => $issue2->id(),
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 12768: 34333 | 34334 | 36350 | 36505 | 36506 | 36552 | 36553 | 36554 | 36555 | 38365 | 38367 | 38368 | 38375 | 39298 | 39299 | 39300 | 39999 | 40000 | 40001 | 40002 | 42157 | 42158 | 43181 | 43546 | 64775 | 64776 | 66760 | 66761 | 67875 | 67876 | 67877 | 67878 | 67891 | 67892 | 67893 | 67894 | 67895 | 67896 | 67897 | 68035 | 68036 | 68037 | 68038 | 68039 | 68040 | 68041 | 68042 | 68076 | 68264 | 68265 | 68266 | 68267 | 68268 | 68269 | 68270 | 68271 | 68272 | 68273 | 68274 | 68332 | 68415 | 68416 | 68417 | 68426 | 68427