Bugzilla – Attachment 68046 Details for
Bug 19296
Tax is being subtracted from orders when vendor price does not include gst and ordering from a file
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19296: (QA Follow-up) Correct comment in populate_orders
Bug-19296-QA-Follow-up-Correct-comment-in-populate.patch (text/plain), 1.16 KB, created by
Marcel de Rooy
on 2017-10-13 07:05:57 UTC
(
hide
)
Description:
Bug 19296: (QA Follow-up) Correct comment in populate_orders
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-10-13 07:05:57 UTC
Size:
1.16 KB
patch
obsolete
>From a265c5e4366136c5122135ac5397fe8b7f983cd7 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 13 Oct 2017 09:03:25 +0200 >Subject: [PATCH] Bug 19296: (QA Follow-up) Correct comment in populate_orders >Content-Type: text/plain; charset=utf-8 > >Just replacing a wrong - by a correct + sign in the comment. The code >itself is fine. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Acquisition.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 950498e..43e46db 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -2965,7 +2965,7 @@ sub populate_order_with_prices { > # ecost tax excluded = rrp tax excluded * ( 1 - discount ) > $order->{ecost_tax_excluded} = $order->{rrp_tax_excluded} * ( 1 - $discount ); > >- # ecost tax included = rrp tax excluded * ( 1 - tax rate ) * ( 1 - discount ) >+ # ecost tax included = rrp tax excluded * ( 1 + tax rate ) * ( 1 - discount ) > $order->{ecost_tax_included} = > $order->{rrp_tax_excluded} * > ( 1 + $order->{tax_rate_on_ordering} ) * >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19296
:
67110
|
67822
|
68045
| 68046