Attachment 6807 Details for Bug 6302 – [SIGNED-OFF] 6302 follow up

[patch] [SIGNED-OFF] 6302 follow up

SIGNED-OFF-6302-follow-up.patch (text/plain), 1.44 KB, created by Koustubha Kale on 2011-12-15 09:45:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Koustubha Kale

Created: 2011-12-15 09:45:38 UTC

Size: 1.44 KB

patch

obsolete

>From 2bb4f36714f503e9e163af5489616f3cf395cda3 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 14 Dec 2011 15:54:22 +0100
>Subject: [PATCH] [SIGNED-OFF] 6302 follow up
>Content-Type: text/plain; charset="utf-8"
>
>Updates to_address in message queue when sending an email (when needed).
>
>Signed-off-by: Koustubha Kale <kmkale@anantcorp.com>
>---
> C4/Letters.pm |    8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 862121c..2420e4a 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -836,8 +836,8 @@ sub _send_message_by_email ($;$$$) {
>     if ( my $bcc = C4::Context->preference('OverdueNoticeBcc') ) {
>        $sendmail_params{ Bcc } = $bcc;
>     }
>-    
> 
>+    _update_message_to_address($message->{'message_id'},$to_address) unless $message->{to_address}; #if initial message address was empty, coming here means that a to address was found and queue should be updated
>     if ( sendmail( %sendmail_params ) ) {
>         _set_message_status( { message_id => $message->{'message_id'},
>                 status     => 'sent' } );
>@@ -863,6 +863,12 @@ sub _send_message_by_sms ($) {
>     return $success;
> }
> 
>+sub _update_message_to_address {
>+    my ($id, $to)= @_;
>+    my $dbh = C4::Context->dbh();
>+    $dbh->do('UPDATE message_queue SET to_address=? WHERE message_id=?',undef,($to,$id));
>+}
>+
> sub _set_message_status ($) {
>     my $params = shift or return undef;
> 
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 6302: 4037 | 6508 | 6605 | 6789 | 6806 | 6807