Attachment 68070 Details for Bug 18923 – Bug 18923: Warning in Biblio::GetCOinSBiblio

[patch] Bug 18923: Warning in Biblio::GetCOinSBiblio

Bug-18923-Warning-in-BiblioGetCOinSBiblio.patch (text/plain), 1.89 KB, created by Julian Maurice on 2017-10-13 12:46:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2017-10-13 12:46:13 UTC

Size: 1.89 KB

patch

obsolete

>From eba8ecfcf6c068a8d354ea1a7c1c1d5a0b9290d3 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 10 Jul 2017 14:54:56 +0200
>Subject: [PATCH] Bug 18923: Warning in Biblio::GetCOinSBiblio
>
>Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456.
>Note: In current master this is now line 1370 (Oct 9, 2017).
>
>Test plan:
>Enable COinSinOPACResults.
>Select a record with leader pos6==a and pos7==a. This triggers genre to be
>journalArticle and titletype to be a.
>Without this patch, do an opac search that includes this record.
>Check the log. You should see the warning.
>Apply this patch, search again and check the log. The warning should not be
>repeated again.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> C4/Biblio.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index baaa325e0c..e3c122825c 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -1367,9 +1367,9 @@ sub GetCOinSBiblio {
>             $isbn      = $record->subfield( '773', 'z' ) || '';
>             $issn      = $record->subfield( '773', 'x' ) || '';
>             if ($mtx eq 'journal') {
>-                $title    .= "&amp;rft.title=" . (($record->subfield( '773', 't' ) || $record->subfield( '773', 'a')));
>+                $title    .= "&amp;rft.title=" . ( $record->subfield( '773', 't' ) || $record->subfield( '773', 'a') || q{} );
>             } else {
>-                $title    .= "&amp;rft.btitle=" . (($record->subfield( '773', 't' ) || $record->subfield( '773', 'a')) || '');
>+                $title    .= "&amp;rft.btitle=" . ( $record->subfield( '773', 't' ) || $record->subfield( '773', 'a') || q{} );
>             }
>             foreach my $rel ($record->subfield( '773', 'g' )) {
>                 if ($pages) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18923: 64961 | 67835 | 67999 | 68070