Bugzilla – Attachment 68156 Details for
Bug 17218
New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17218: [FOLLOW-UP] Stop DB user from adding list by forcing URL
Bug-17218-FOLLOW-UP-Stop-DB-user-from-adding-list-.patch (text/plain), 2.12 KB, created by
Katrin Fischer
on 2017-10-15 08:21:57 UTC
(
hide
)
Description:
Bug 17218: [FOLLOW-UP] Stop DB user from adding list by forcing URL
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-10-15 08:21:57 UTC
Size:
2.12 KB
patch
obsolete
>From 2db93817e787d5c20d34a680251c48e2900b5247 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Tue, 29 Aug 2017 21:41:32 +0000 >Subject: [PATCH] Bug 17218: [FOLLOW-UP] Stop DB user from adding list by > forcing URL > >To test: >1) Go to the url /virtualshelves/shelves.pl?op=add_form&referer=add_form >2) Confirm an error message shows and the Save button cannot be clicked > >Sponsored-by: Catalyst IT > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index 6786c24..47d1893 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -546,6 +546,10 @@ function AdjustRemark() { > <div class="yui-ge"> > <div class="yui-u first"> > <form method="post" action="/cgi-bin/koha/virtualshelves/shelves.pl" class="validated"> >+ [% IF loggedinuser == 0 %] >+ <div class="dialog alert">Lists cannot be created or edited with the database administrator account.</div> >+ [% END %] >+ > <fieldset class="rows"> > > [% IF op == 'add_form' %] >@@ -601,10 +605,14 @@ function AdjustRemark() { > </fieldset> > > <fieldset class="action"> >- <input type="submit" value="Save" class="submit" /> >+ [% IF loggedinuser == 0 %] >+ <input type="submit" value="Save" class="submit" disabled="disabled"> >+ [% ELSE %] >+ <input type="submit" value="Save" class="submit"> >+ [% END %] > [% IF referer == 'view' %] > <a href="/cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=[% shelf.shelfnumber %]" class="cancel">Cancel</a> >- [% ELSE %] >+ [% ELSE %] > [% IF category == PUBLIC %] > <a href="/cgi-bin/koha/virtualshelves/shelves.pl?op=list&category=[% PUBLIC %]" class="cancel">Cancel</a> > [% ELSE %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17218
:
62348
|
66604
|
68155
|
68156
|
72298
|
72299
|
72495
|
72506
|
72507
|
72508