Bugzilla – Attachment 68243 Details for
Bug 18206
REST API: Default exception handling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18206 - REST API: Default exception handling - Squashable, fix regexp
Bug-18206---REST-API-Default-exception-handling---.patch (text/plain), 1.28 KB, created by
Olli-Antti Kivilahti
on 2017-10-18 11:51:10 UTC
(
hide
)
Description:
Bug 18206 - REST API: Default exception handling - Squashable, fix regexp
Filename:
MIME Type:
Creator:
Olli-Antti Kivilahti
Created:
2017-10-18 11:51:10 UTC
Size:
1.28 KB
patch
obsolete
>From f9fd51e0263653fe994a272c166b10c0ecc89099 Mon Sep 17 00:00:00 2001 >From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> >Date: Wed, 18 Oct 2017 14:49:52 +0300 >Subject: [PATCH] Bug 18206 - REST API: Default exception handling - > Squashable, fix regexp > >t/db_dependent/api/v1.t .. Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/ERROR - Unknown::Exception::OhNo => { <-- HERE "what":"test unknown exception"}/ at t/db_dependent/api/v1.t line 100. >--- > t/db_dependent/api/v1.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/api/v1.t b/t/db_dependent/api/v1.t >index 832fa4e..b5804b5 100644 >--- a/t/db_dependent/api/v1.t >+++ b/t/db_dependent/api/v1.t >@@ -97,7 +97,7 @@ subtest 'default_exception_handling() tests' => sub { > $t->get_ok('/default_exception_handling/unknown') > ->status_is(500) > ->json_is('/error' => 'Something went wrong, check the logs.'); >- like($appender->buffer, qr/ERROR - Unknown::Exception::OhNo => {"what":"test unknown exception"}/, >+ like($appender->buffer, qr/ERROR - Unknown::Exception::OhNo => \{"what":"test unknown exception"\}/, > 'Found test unknown exception in log'); > $appender->{appender}->{buffer} = undef; > }; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18206
:
61072
|
61073
|
61087
|
61088
|
61170
|
61171
|
68243
|
69229
|
69230
|
69231
|
85715
|
85716
|
85717