Attachment 68268 Details for Bug 12768 – Bug 12768 - Revert changes to getcharges

[patch] Bug 12768 - Revert changes to getcharges

Bug-12768---Revert-changes-to-getcharges.patch (text/plain), 1.35 KB, created by Nick Clemens (kidclamp) on 2017-10-18 16:43:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-10-18 16:43:30 UTC

Size: 1.35 KB

patch

obsolete

>From 43784a899e6dd8e62954076516caf22b9ffce002 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 10 Oct 2017 10:40:19 -0400
>Subject: [PATCH] Bug 12768 - Revert changes to getcharges
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Accounts.pm | 23 ++++++++---------------
> 1 file changed, 8 insertions(+), 15 deletions(-)
>
>diff --git a/C4/Accounts.pm b/C4/Accounts.pm
>index a59e263..256f7b2 100644
>--- a/C4/Accounts.pm
>+++ b/C4/Accounts.pm
>@@ -299,22 +299,15 @@ sub manualinvoice {
> }
> 
> sub getcharges {
>-    my ( $borrowerno, $accountno ) = @_;
>-    my $dbh = C4::Context->dbh;
>-
>-    my @params;
>-
>-    my $query = "SELECT * FROM accountlines WHERE borrowernumber = ?";
>-    push( @params, $borrowerno );
>-
>-    if ( $accountno ) {
>-        $query .= " AND accountno = ?";
>-        push( @params, $accountno );
>-    }
>+    my ( $borrowerno, $timestamp, $accountno ) = @_;
>+    my $dbh        = C4::Context->dbh;
>+    my $timestamp2 = $timestamp - 1;
>+    my $query      = "";
>+    my $sth = $dbh->prepare(
>+            "SELECT * FROM accountlines WHERE borrowernumber=? AND accountno = ?"
>+          );
>+    $sth->execute( $borrowerno, $accountno );
> 
>-    my $sth = $dbh->prepare( $query );
>-    $sth->execute( @params );
>-	
>     my @results;
>     while ( my $data = $sth->fetchrow_hashref ) {
>         push @results,$data;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 12768: 34333 | 34334 | 36350 | 36505 | 36506 | 36552 | 36553 | 36554 | 36555 | 38365 | 38367 | 38368 | 38375 | 39298 | 39299 | 39300 | 39999 | 40000 | 40001 | 40002 | 42157 | 42158 | 43181 | 43546 | 64775 | 64776 | 66760 | 66761 | 67875 | 67876 | 67877 | 67878 | 67891 | 67892 | 67893 | 67894 | 67895 | 67896 | 67897 | 68035 | 68036 | 68037 | 68038 | 68039 | 68040 | 68041 | 68042 | 68076 | 68264 | 68265 | 68266 | 68267 | 68268 | 68269 | 68270 | 68271 | 68272 | 68273 | 68274 | 68332 | 68415 | 68416 | 68417 | 68426 | 68427