Bugzilla – Attachment 68285 Details for
Bug 19484
Checkout page does not like itemtype NULL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19484: Add test before using object itemtype
Bug-19484-Add-test-before-using-object-itemtype.patch (text/plain), 1.23 KB, created by
Dilan Johnpullé
on 2017-10-19 00:13:19 UTC
(
hide
)
Description:
Bug 19484: Add test before using object itemtype
Filename:
MIME Type:
Creator:
Dilan Johnpullé
Created:
2017-10-19 00:13:19 UTC
Size:
1.23 KB
patch
obsolete
>From 1c6d08a7f282f171e0a2fb969b0dbd0ea36a705f Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 18 Oct 2017 16:00:34 +0200 >Subject: [PATCH] Bug 19484: Add test before using object itemtype >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Patch applies and functions as described. I agree with you that importing NULL itemtypes is possible Marcel. A higher importance level makes sense. > >Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> >--- > svc/checkouts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/svc/checkouts b/svc/checkouts >index 98251b5..e42f369 100755 >--- a/svc/checkouts >+++ b/svc/checkouts >@@ -171,7 +171,7 @@ while ( my $c = $sth->fetchrow_hashref() ) { > author => $c->{author}, > barcode => $c->{barcode}, > itemtype => $item_level_itypes ? $c->{itype} : $c->{itemtype}, >- itemtype_description => $itemtype->translated_description, >+ itemtype_description => $itemtype ? $itemtype->translated_description : q{}, > location => $location, > homebranch => $c->{homebranch}, > itemnotes => $c->{itemnotes}, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19484
:
68250
|
68285
|
68703