Bugzilla – Attachment 68290 Details for
Bug 16187
Add a script to cancel unfilled holds after a specified number of days
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16187 - Followup
Bug-16187---Followup.patch (text/plain), 2.35 KB, created by
Nick Clemens (kidclamp)
on 2017-10-19 09:59:38 UTC
(
hide
)
Description:
Bug 16187 - Followup
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-10-19 09:59:38 UTC
Size:
2.35 KB
patch
obsolete
>From 44e3d34bc59fa054f75ffd1128dbaa4d3ca89b24 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 19 Oct 2017 09:57:22 +0000 >Subject: [PATCH] Bug 16187 - Followup > >1 - Correct use of original (bad) script name >2 - Explain options better >3 - Remove change from 'W' to 'w' >--- > Koha/Holds.pm | 2 +- > misc/cronjobs/holds/cancel_unfilled_holds.pl | 9 +++++---- > t/db_dependent/Holds.t | 2 +- > 3 files changed, 7 insertions(+), 6 deletions(-) > >diff --git a/Koha/Holds.pm b/Koha/Holds.pm >index ca664c3..f5da469 100644 >--- a/Koha/Holds.pm >+++ b/Koha/Holds.pm >@@ -46,7 +46,7 @@ returns a set of holds that are waiting from an existing set > sub waiting { > my ( $self ) = @_; > >- return $self->search( { found => 'w' } ); >+ return $self->search( { found => 'W' } ); > } > > =head3 unfilled >diff --git a/misc/cronjobs/holds/cancel_unfilled_holds.pl b/misc/cronjobs/holds/cancel_unfilled_holds.pl >index 69aaa6e..29e7472 100755 >--- a/misc/cronjobs/holds/cancel_unfilled_holds.pl >+++ b/misc/cronjobs/holds/cancel_unfilled_holds.pl >@@ -39,16 +39,16 @@ cronlogaction(); > > =head1 NAME > >-cancel_waiting_holds.pl >+cancel_unfilled_holds.pl > > =head1 SYNOPSIS > >-cancel_waiting_holds.pl >+cancel_unfilled_holds.pl > [-days][-library][-holidays] > > Options: > -help brief help >- -days cancel holds waiting this many days >+ -days cancel holds placed this many days ago which have not been filled > -library [repeatable] limit to specified branch(es) > -holidays skip holidays when calculating days waiting > -v verbose >@@ -67,7 +67,8 @@ Print full documentation and exit. > > =item B<-days> > >-Specify the number of days waiting upon which to cancel holds. >+Specify the number of days waiting since a hold that remains unfilled was placed. >+E.g. a value of 730 would cancel holds placed 2 years ago or more that have never been filled > > =item B<-library> > >diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t >index 30e3917..06ef97e 100755 >--- a/t/db_dependent/Holds.t >+++ b/t/db_dependent/Holds.t >@@ -7,7 +7,7 @@ use t::lib::TestBuilder; > > use C4::Context; > >-use Test::More tests => 59; >+use Test::More tests => 54; > use MARC::Record; > use C4::Biblio; > use C4::Items; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16187
:
53397
|
56275
|
61173
|
61951
|
64924
|
68289
|
68290
|
68309
|
68310
|
68311