Bugzilla – Attachment 6830 Details for
Bug 7355
Note subfields are not displayed in TEXTAREA if hidden
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-7355-Note-subfields-are-not-displayed-in-TEXTARE.patch (text/plain), 2.01 KB, created by
Frédéric Demians
on 2011-12-16 07:35:05 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2011-12-16 07:35:05 UTC
Size:
2.01 KB
patch
obsolete
>From 7b921b753d3b306cb9d7f44fb808b659f5fdeb54 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Wed, 14 Dec 2011 08:52:32 +0100 >Subject: [PATCH] Bug 7355 Note subfields are not displayed in TEXTAREA if > hidden > >In the data entry form, there is a (hidden) functionality for note subfields. >MARC21 500-599 and UNIMARC 300-399 subfields are displayed in TEXTAREA rather >than INPUT tags. This is good since usually notes can be pretty long. But if >one of those fields is marked in the framework as 'hidden', then it isn't >displayed at first when you create a record and when you expand the field by >clicking on its label the field is displayed in a one-line INPUT tag. > >To reproduce this bug: > >- Modify your framework: > MARC21: 500$a, hidden=1 > UNIMARC: 300$a, hidden=1 >- Create a new biblio record with this framework >- Open the tab containing 500 or 300 field >- 500 or 300 tab is collapsed >- Click on 500 or 300 label to expand the field >- 500$a or 300$a is displayed in a one-line INPUT tag, not in a TEXTAREA > as it should >--- > cataloguing/addbiblio.pl | 15 +-------------- > 1 files changed, 1 insertions(+), 14 deletions(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index 71d43d7..a1c598a 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -467,21 +467,8 @@ sub create_input { > value=\"$value\" \/> > "; > } >- elsif ( $tagslib->{$tag}->{$subfield}->{'hidden'} ) { >- $subfield_data{marc_value} = >- "<input type=\"text\" >- id=\"".$subfield_data{id}."\" >- name=\"".$subfield_data{id}."\" >- class=\"input_marceditor\" >- tabindex=\"1\" >- size=\"67\" >- maxlength=\"$max_length\" >- value=\"$value\" >- \/>"; >- >- # it's a standard field >- } > else { >+ # it's a standard field > if ( > length($value) > 100 > or >-- >1.7.8 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7355
:
6776
|
6830
|
6846
|
7434