Bugzilla – Attachment 68333 Details for
Bug 19503
Duplicating a dropdown menu subfield yields an empty subfield tag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19503: Duplicating a dropdown menu subfield yields an empty subfield tag
Bug-19503-Duplicating-a-dropdown-menu-subfield-yie.patch (text/plain), 1.95 KB, created by
Andreas Roussos
on 2017-10-20 20:28:54 UTC
(
hide
)
Description:
Bug 19503: Duplicating a dropdown menu subfield yields an empty subfield tag
Filename:
MIME Type:
Creator:
Andreas Roussos
Created:
2017-10-20 20:28:54 UTC
Size:
1.95 KB
patch
obsolete
>From a4701a734209113e484b73e581cb18c715d5906d Mon Sep 17 00:00:00 2001 >From: Andreas Roussos <arouss1980@gmail.com> >Date: Fri, 20 Oct 2017 22:58:27 +0300 >Subject: [PATCH] Bug 19503: Duplicating a dropdown menu subfield yields an > empty subfield tag > >While editing a record in the staff client, if you clone a repeatable >dropdown subfield the cloned subfield's tag is empty. This can result >in data loss if the record is saved, re-opened, and saved yet again. >This patch (originally written by Sophie MEYNIEUX for bug 17818) fixes that. > >Test plan: >0) [PREREQUISITE] In your MARC framework (Home > Administration > MARC > bibliographic framework) ensure that you have at least one subfield > of a particular tag linked to an authorised value (e.g. in UNIMARC, > tag 700 subfield 4 is 'Relator Code' and can be linked to CCODE for > testing purposes). This is so that the relevant subfield will be a > dropdown menu and not a textbox. >1) In the Staff Client, edit an existing record or create a new one. > Then, try to clone any subfield that is a dropdown menu. Observe > that the cloned subfield's tag is empty. >2) Apply the patch. >3) Hit CTRL-F5 in your browser (to ensure cataloging.js is re-loaded) > and try to clone a dropdown menu subfield again. This time the tag > is cloned as well. >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index a4aa6cf4b8..d9f0e82c14 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -282,6 +282,7 @@ function CloneSubfield(index, advancedMARCEditor){ > id_input = selects[i].getAttribute('id')+new_key; > selects[i].setAttribute('id',selects[i].getAttribute('id')+new_key); > selects[i].setAttribute('name',selects[i].getAttribute('name')+new_key); >+ linkid = id_input; > } > > // textarea >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19503
:
68331
|
68333
|
68373
|
68686