Attachment 68346 Details for Bug 16759 – [SIGNED-OFF] Bug 16759: (followup) Make it work with OpacSeparateHoldings

[patch] [SIGNED-OFF] Bug 16759: (followup) Make it work with OpacSeparateHoldings

SIGNED-OFF-Bug-16759-followup-Make-it-work-with-Op.patch (text/plain), 2.02 KB, created by Alex Buckley on 2017-10-21 04:49:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2017-10-21 04:49:55 UTC

Size: 2.02 KB

patch

obsolete

>From 89dc1b891de91deddecdfbbfb38a1f13932bab3f Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 4 Aug 2017 15:37:45 -0300
>Subject: [PATCH] [SIGNED-OFF] Bug 16759: (followup) Make it work with
> OpacSeparateHoldings
>
>This patch fixes columns_settings.inc so it works for all objects when
>the selector returns more than one object.
>
>To test:
>- Have the first patch applied
>- Verify it works correctly
>- Enable OpacSeparateHoldings
>- Reload
>=> FAIL: Notice the second holdings tab doesn't have the visualization
>rules applied.
>- Apply this patch
>- Reload
>=> SUCCESS: Rules applied correctly!
>- Sign off :-D
>
>Edit: amended so it preserves the original semantic, returning the
>resulting table objects.
>
>Sponsored-by: Dover
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Followed test plan, patch worked as described. Also passed QA test tool
>Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
>---
> .../opac-tmpl/bootstrap/en/includes/columns_settings.inc      | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/columns_settings.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/columns_settings.inc
>index b065a35..9a04036 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/columns_settings.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/columns_settings.inc
>@@ -25,13 +25,16 @@ function KohaTable(selector, dt_parameters, columns_settings) {
>             text: _("Column visibility"),
>         }
>     ];
>-    var table = $(selector).dataTable($.extend(true, {}, dataTablesDefaults, dt_parameters));
> 
>-    $(hidden_ids).each(function(index, value) {
>-        table.fnSetColumnVis( value, false );
>+    var tables = $(selector).map(function(){
>+        var table = $(this).dataTable($.extend(true, {}, dataTablesDefaults, dt_parameters));
>+        $(hidden_ids).each(function(index, value) {
>+            table.fnSetColumnVis(value, false);
>+        });
>+        return table;
>     });
> 
>-    return table;
>+    return tables;
> }
> 
> </script>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16759: 65401 | 65512 | 65513 | 65563 | 65564 | 68342 | 68343 | 68344 | 68345 | 68346 | 68464 | 68465 | 68507 | 68528