Bugzilla – Attachment 68445 Details for
Bug 7317
Add an Interlibrary Loan Module to Circulation and OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7317: (followup) Migrate endpoint to OpenAPI
Bug-7317-followup-Migrate-endpoint-to-OpenAPI.patch (text/plain), 3.52 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-10-23 19:08:03 UTC
(
hide
)
Description:
Bug 7317: (followup) Migrate endpoint to OpenAPI
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-10-23 19:08:03 UTC
Size:
3.52 KB
patch
obsolete
>From e1957dab30da5d9f63ac272fe98b96307d360c5d Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 23 Oct 2017 15:34:01 -0300 >Subject: [PATCH] Bug 7317: (followup) Migrate endpoint to OpenAPI > >This patch moves the current endpoint implementation from Swagger2 to >the OpenAPI plugin. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/REST/V1/Illrequests.pm | 10 +++++----- > api/v1/swagger/paths/illrequests.json | 36 ++++++++++++++++++++++++++++++++--- > 2 files changed, 38 insertions(+), 8 deletions(-) > >diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm >index 0807eb1..ba47556 100644 >--- a/Koha/REST/V1/Illrequests.pm >+++ b/Koha/REST/V1/Illrequests.pm >@@ -20,13 +20,13 @@ use Modern::Perl; > use Mojo::Base 'Mojolicious::Controller'; > > use Koha::Illrequests; >-use Koha::Library; >+use Koha::Libraries; > > sub list { >- my ($c, $args, $cb) = @_; >+ my $c = shift->openapi->valid_input or return; > >+ my $args = $c->req->params->to_hash // {}; > my $filter; >- $args //= {}; > my $output = []; > > # Create a hash where all keys are embedded values >@@ -45,7 +45,7 @@ sub list { > my $requests = Koha::Illrequests->search($filter); > > while (my $request = $requests->next) { >- my $unblessed = $request->unblessed; >+ my $unblessed = $request->TO_JSON; > # Add the request's id_prefix > $unblessed->{id_prefix} = $request->id_prefix; > # Augment the request response with patron details >@@ -78,7 +78,7 @@ sub list { > push @{$output}, $unblessed > } > >- return $c->$cb( $output, 200 ); >+ return $c->render( status => 200, openapi => $output ); > > } > >diff --git a/api/v1/swagger/paths/illrequests.json b/api/v1/swagger/paths/illrequests.json >index ddafd80..84eb5f1 100644 >--- a/api/v1/swagger/paths/illrequests.json >+++ b/api/v1/swagger/paths/illrequests.json >@@ -1,8 +1,8 @@ > { > "/illrequests": { > "get": { >- "x-mojo-controller": "Koha::REST::V1::Illrequests", >- "operationId": "list", >+ "x-mojo-to": "Illrequests#list", >+ "operationId": "listIllrequests", > "tags": ["illrequests"], > "parameters": [{ > "name": "embed", >@@ -85,7 +85,37 @@ > ], > "responses": { > "200": { >- "description": "OK" >+ "description": "A list of ILL requests" >+ }, >+ "401": { >+ "description": "Authentication required", >+ "schema": { >+ "$ref": "../definitions.json#/error" >+ } >+ }, >+ "403": { >+ "description": "Access forbidden", >+ "schema": { >+ "$ref": "../definitions.json#/error" >+ } >+ }, >+ "404": { >+ "description": "ILL requests not found", >+ "schema": { >+ "$ref": "../definitions.json#/error" >+ } >+ }, >+ "500": { >+ "description": "Internal server error", >+ "schema": { >+ "$ref": "../definitions.json#/error" >+ } >+ }, >+ "503": { >+ "description": "Under maintenance", >+ "schema": { >+ "$ref": "../definitions.json#/error" >+ } > } > }, > "x-koha-authorization": { >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7317
:
59893
|
59894
|
59895
|
59920
|
60485
|
60486
|
60487
|
60488
|
63081
|
63082
|
63083
|
63084
|
63085
|
63086
|
63087
|
63088
|
63089
|
63090
|
63113
|
63175
|
63176
|
63354
|
63421
|
63472
|
63475
|
65469
|
65470
|
65471
|
65472
|
65473
|
65474
|
65475
|
65476
|
66266
|
67242
|
67243
|
67244
|
67245
|
67246
|
67247
|
67248
|
67249
|
67250
|
67251
|
67252
|
67253
|
67254
|
67255
|
67256
|
67257
|
67258
|
67259
|
67260
|
67261
|
67262
|
67263
|
67264
|
67281
|
67282
|
67283
|
67284
|
67285
|
67286
|
67287
|
67288
|
67289
|
67290
|
67291
|
67292
|
67293
|
67294
|
67295
|
67296
|
67297
|
67298
|
67299
|
67300
|
67301
|
67302
|
67303
|
68185
|
68186
|
68328
|
68391
|
68406
|
68407
|
68408
|
68409
|
68418
|
68444
|
68445
|
68483
|
68484
|
68485
|
68487
|
68516
|
68517
|
68518
|
68519
|
68520
|
68521
|
68522
|
68523
|
68524
|
68525
|
68542
|
68543
|
68544
|
68545
|
68546
|
68547
|
68548
|
68549
|
68550
|
68551
|
68552
|
68558
|
68559
|
68560
|
68561
|
68562
|
68563
|
68564
|
68565
|
68566
|
68567
|
68858
|
68874
|
68877
|
68878
|
68885
|
68886
|
68921
|
68922
|
68926
|
68927
|
68928
|
68929
|
68931
|
68932
|
68933
|
68988
|
68989
|
68999
|
69000
|
69006
|
69008
|
69009
|
69012
|
69014
|
69044
|
69045
|
69046
|
69056
|
69059
|
69060
|
69061
|
69063
|
69064
|
69065
|
69066
|
69069
|
69070
|
69071
|
69074