Bugzilla – Attachment 6847 Details for
Bug 7364
Fast-Add framework doesn't always get the branch for item creation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7364: Possible to get to FA item add without current branch being defined.
Bug-7364-Possible-to-get-to-FA-item-add-without-cu.patch (text/plain), 1.29 KB, created by
Chris Cormack
on 2011-12-18 07:20:36 UTC
(
hide
)
Description:
Bug 7364: Possible to get to FA item add without current branch being defined.
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2011-12-18 07:20:36 UTC
Size:
1.29 KB
patch
obsolete
>From add24f3554ac132d6881379338446b98f2caaa82 Mon Sep 17 00:00:00 2001 >From: D Ruth Bavousett <ruth@bywatersolutions.com> >Date: Fri, 16 Dec 2011 10:38:47 -0500 >Subject: [PATCH] Bug 7364: Possible to get to FA item add without current > branch being defined. > >Some paths to the FA item-add screen didn't have a branch defined--if the param is set, >use it, otherwise, use the user's logged in branch. > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > cataloguing/additem.pl | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 70ca4a9..cbad0b6 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -661,10 +661,7 @@ my $onlymine = C4::Context->preference('IndependantBranches') && > C4::Context->userenv && > C4::Context->userenv->{flags}!=1 && > C4::Context->userenv->{branch}; >-my $branch = C4::Context->userenv->{branch}; >-if ($frameworkcode eq 'FA'){ >- $branch = $input->param('branch'); >-} >+my $branch = $input->param{'branch'} || C4::Context->userenv->{branch}; > my $branches = GetBranchesLoop($branch,$onlymine); # build once ahead of time, instead of multiple times later. > > # We generate form, from actuel record >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7364
:
6835
|
6847
|
7176