Bugzilla – Attachment 68475 Details for
Bug 13178
cardnumber field length is too short
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13178: QA Followup - fix kohastructure and update info in fields
Bug-13178-QA-Followup---fix-kohastructure-and-upda.patch (text/plain), 5.50 KB, created by
Nick Clemens (kidclamp)
on 2017-10-24 15:10:42 UTC
(
hide
)
Description:
Bug 13178: QA Followup - fix kohastructure and update info in fields
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-10-24 15:10:42 UTC
Size:
5.50 KB
patch
obsolete
>From 3553777363530e9947b2f0992adefd8ffca8f935 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 24 Oct 2017 15:04:32 +0000 >Subject: [PATCH] Bug 13178: QA Followup - fix kohastructure and update info in > fields > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > installer/data/mysql/kohastructure.sql | 10 +++++----- > installer/data/mysql/sysprefs.sql | 2 +- > .../prog/en/modules/admin/preferences/patrons.pref | 2 +- > 3 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 379c100..e547168 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -568,7 +568,7 @@ CREATE TABLE `deletedbiblioitems` ( -- information about bibliographic records t > DROP TABLE IF EXISTS `deletedborrowers`; > CREATE TABLE `deletedborrowers` ( -- stores data related to the patrons/borrowers you have deleted > `borrowernumber` int(11) NOT NULL default 0, -- primary key, Koha assigned ID number for patrons/borrowers >- `cardnumber` varchar(16) default NULL, -- unique key, library assigned ID number for patrons/borrowers >+ `cardnumber` varchar(32) default NULL, -- unique key, library assigned ID number for patrons/borrowers > `surname` mediumtext NOT NULL, -- patron/borrower's last name (surname) > `firstname` text, -- patron/borrower's first name > `title` mediumtext, -- patron/borrower's title, for example: Mr. or Mrs. >@@ -1379,7 +1379,7 @@ CREATE TABLE pending_offline_operations ( > `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, > `action` varchar(10) NOT NULL, > barcode varchar(20) DEFAULT NULL, >- cardnumber varchar(16) DEFAULT NULL, >+ cardnumber varchar(32) DEFAULT NULL, > amount decimal(28,6) DEFAULT NULL, > PRIMARY KEY (operationid) > ) ENGINE=MyISAM DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; >@@ -1608,7 +1608,7 @@ CREATE TABLE `sms_providers` ( > DROP TABLE IF EXISTS `borrowers`; > CREATE TABLE `borrowers` ( -- this table includes information about your patrons/borrowers/members > `borrowernumber` int(11) NOT NULL auto_increment, -- primary key, Koha assigned ID number for patrons/borrowers >- `cardnumber` varchar(16) default NULL, -- unique key, library assigned ID number for patrons/borrowers >+ `cardnumber` varchar(32) default NULL, -- unique key, library assigned ID number for patrons/borrowers > `surname` mediumtext NOT NULL, -- patron/borrower's last name (surname) > `firstname` text, -- patron/borrower's first name > `title` mediumtext, -- patron/borrower's title, for example: Mr. or Mrs. >@@ -2497,7 +2497,7 @@ CREATE TABLE `tmp_holdsqueue` ( > `firstname` text, > `phone` text, > `borrowernumber` int(11) NOT NULL, >- `cardnumber` varchar(16) default NULL, >+ `cardnumber` varchar(32) default NULL, > `reservedate` date default NULL, > `title` mediumtext, > `itemcallnumber` varchar(255) default NULL, >@@ -3405,7 +3405,7 @@ CREATE TABLE IF NOT EXISTS `borrower_modifications` ( > `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, > `verification_token` varchar(255) NOT NULL DEFAULT '', > `borrowernumber` int(11) NOT NULL DEFAULT '0', >- `cardnumber` varchar(16) DEFAULT NULL, >+ `cardnumber` varchar(32) DEFAULT NULL, > `surname` mediumtext, > `firstname` text, > `title` mediumtext, >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 9d36385..4cf359c 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -93,7 +93,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('CalculateFinesOnReturn','1','','Switch to control if overdue fines are calculated on return or not','YesNo'), > ('CalendarFirstDayOfWeek','0','0|1|2|3|4|5|6','Select the first day of week to use in the calendar.','Choice'), > ('canreservefromotherbranches','1','','With Independent branches on, can a user from one library place a hold on an item from another library','YesNo'), >-('CardnumberLength', '', '', 'Set a length for card numbers.', 'Free'), >+('CardnumberLength', '', '', 'Set a length for card numbers with a maximum of 32 characters.', 'Free'), > ('casAuthentication','0','','Enable or disable CAS authentication','YesNo'), > ('casLogout','0','','Does a logout from Koha should also log the user out of CAS?','YesNo'), > ('casServerUrl','https://localhost:8443/cas','','URL of the cas server','Free'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >index f52cd2e..b953ae6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >@@ -174,7 +174,7 @@ Patrons: > - Card numbers for patrons must be > - pref: CardnumberLength > - "characters long. The length can be a single number to specify an exact length, a range separated by a comma (i.e., 'Min,Max'), or a maximum with no minimum (i.e., ',Max')." >- - "If 'cardnumber' is included in the BorrowerMandatoryField list, the minimum length, if not specified here, defaults to one. Maximum cannot be bigger than the database field size." >+ - "If 'cardnumber' is included in the BorrowerMandatoryField list, the minimum length, if not specified here, defaults to one. Maximum cannot be bigger than the database field size of 32." > - > - pref: useDischarge > choices: >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13178
:
64428
|
64487
|
64644
|
64645
|
64646
|
64647
|
68473
|
68474
|
68475
|
68553
|
68554
|
68555