Attachment 68648 Details for Bug 16782 – Bug 16782 - disclose JSON URL for reports on the saved report page

[patch] Bug 16782 - disclose JSON URL for reports on the saved report page

Bug-16782---disclose-JSON-URL-for-reports-on-the-s.patch (text/plain), 3.49 KB, created by Mark Tompsett on 2017-10-27 00:52:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2017-10-27 00:52:16 UTC

Size: 3.49 KB

patch

obsolete

>From 940fb5e023716aadfa6935c66e653e1bc5c17e5b Mon Sep 17 00:00:00 2001
>From: Liz Rea <liz@catalyst.net.nz>
>Date: Thu, 19 Oct 2017 16:23:43 +1300
>Subject: [PATCH] Bug 16782 - disclose JSON URL for reports on the saved report
> page
>
>It has always annoyed me that you had to look at the help to divine the url for a report.
>This patch works it out and displays it for you in a new column on the saved reports table.
>
>Requirements:
>- OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be complete. It's ok if they are not, but it's better if they are.
>- You must have a saved report that is public to your OPAC, and one that is not public.
>
>To test:
>- create a public saved report and a private staff report. They can be anything.
>- view the saved reports page, note that under a new heading of JSON URL the link to the json feed for that report shows.
>- copying and pasting that link into the address bar, or clicking it, should take you to the results of the selected report.
>
>sponsored-by: Catalyst IT
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> .../prog/en/modules/reports/guided_reports_start.tt | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 5902b92..c2550c6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -389,6 +389,7 @@ canned reports and writing custom SQL reports.
> <th class="title-string">Last edit</th>
> <th class="title-string">Last run</th>
> <th>Public</th>
>+ <th>JSON URL</th>
> [% IF (usecache) %] <th>Cache expiry (seconds)</th> [% END %]
> <th>Saved results</th>
> [% IF has_obsolete_reports %]<th>Update</th>[% END %]
>@@ -419,11 +420,19 @@ canned reports and writing custom SQL reports.
> <td>[% savedreport.date_created | $KohaDates %]</td>
> <td>[% savedreport.last_modified | $KohaDates with_hours => 1 %]</td>
> <td>[% savedreport.last_run | $KohaDates with_hours => 1 %]</td>
>+ <td>
>+ [% IF (savedreport.public) %]
>+ Yes
>+ [% ELSE %]
>+ No
>+ [% END %]
>+ <td>
> [% IF (savedreport.public) %]
>- <td>Yes</td>
>+ <a href="[% OPACBaseURL %]/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]">[% OPACBaseURL %]/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]</a>
> [% ELSE %]
>- <td>No</td>
>+ <a href="/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]">[% staffClientBaseURL %]/cgi-bin/koha/svc/report?id=[% savedreport.id | html %]</a>
> [% END %]
>+ </td>
> [% IF (usecache) %] <td>[% savedreport.cache_expiry %]</td> [% END %]
> <td>
> [% FOR result IN savedreport.results %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16782: 68286 | 68287 | 68446 | 68447 | 68619 | 68620 | 68621 | 68639 | 68648 | 68649 | 70322 | 70323 | 70324 | 70395