Bugzilla – Attachment 68690 Details for
Bug 19029
Implement a security question for cloning circulation conditions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19029 - Followup: Make security question appear on clone operations from one library to another
Bug-19029---Followup-Make-security-question-appear.patch (text/plain), 2.14 KB, created by
Kyle M Hall (khall)
on 2017-10-27 12:56:08 UTC
(
hide
)
Description:
Bug 19029 - Followup: Make security question appear on clone operations from one library to another
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-10-27 12:56:08 UTC
Size:
2.14 KB
patch
obsolete
>From 6820c7c070d81e6a17d9cfa9fe02e1864311bd6e Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 11 Oct 2017 13:41:27 +0000 >Subject: [PATCH] Bug 19029 - Followup: Make security question appear on clone > operations from one library to another >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Message pops up for all instances of cloning now. >Works as expected. > >Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index d499c6e..bfec588 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -37,9 +37,14 @@ $(document).ready(function() { > $("#clone_rules").on("click",function(){ > var library_dropdown = document.getElementById("branch"); > var selected_library = library_dropdown.options[library_dropdown.selectedIndex].value; >+ var selected_library_text = $("#branch option:selected").text(); >+ var to_library = $("#tobranch option:selected").text(); >+ var MSG_CONFIRM_CLONE; > if (selected_library === "*") { >- var to_library = $("#tobranch option:selected").text(); >- var MSG_CONFIRM_CLONE = _("Are you sure you want to clone this standard rule to %s library? This will override the existing rules in this library.").format(to_library); >+ MSG_CONFIRM_CLONE = _("Are you sure you want to clone this standard rule to %s library? This will override the existing rules in this library.").format(to_library); >+ return confirmClone(MSG_CONFIRM_CLONE); >+ } else { >+ MSG_CONFIRM_CLONE = _("Are you sure you want to clone this circulation and fine rule from %s to %s library? This will override the existing rules in this library.").format(selected_library_text, to_library); > return confirmClone(MSG_CONFIRM_CLONE); > } > }); >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19029
:
66519
|
67323
|
67529
|
67980
|
67983
|
68688
|
68689
| 68690