Attachment 68791 Details for Bug 15486 – Bug 18282: operationId must be unique

[patch] Bug 18282: operationId must be unique

Bug-18282-operationId-must-be-unique.patch (text/plain), 2.14 KB, created by Dominic Pichette on 2017-10-27 20:10:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dominic Pichette

Created: 2017-10-27 20:10:14 UTC

Size: 2.14 KB

patch

obsolete

>From 08d7d33812ccad3a3bb3b8331012c820ab48ea91 Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Thu, 16 Mar 2017 13:53:44 +0200
>Subject: [PATCH] Bug 18282: operationId must be unique
>
>operationId has the following documentation:
> "Unique string used to identify the operation. The id MUST be unique among all
>  operations described in the API."
>
>This patch modifies operationIds to be unique accross our API operations.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Dominic Pichette <dominic@inlibro.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=15486
>---
> api/v1/swagger/paths/cities.json | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/api/v1/swagger/paths/cities.json b/api/v1/swagger/paths/cities.json
>index 8b739d6..2fe9f49 100644
>--- a/api/v1/swagger/paths/cities.json
>+++ b/api/v1/swagger/paths/cities.json
>@@ -2,7 +2,7 @@
>   "/cities": {
>     "get": {
>       "x-mojo-to": "Cities#list",
>-      "operationId": "list",
>+      "operationId": "listCities",
>       "tags": ["cities"],
>       "produces": [
>         "application/json"
>@@ -64,7 +64,7 @@
>     },
>     "post": {
>       "x-mojo-to": "Cities#add",
>-      "operationId": "add",
>+      "operationId": "addCity",
>       "tags": ["cities"],
>       "parameters": [{
>         "name": "body",
>@@ -120,7 +120,7 @@
>   "/cities/{cityid}": {
>     "get": {
>       "x-mojo-to": "Cities#get",
>-      "operationId": "get",
>+      "operationId": "getCity",
>       "tags": ["cities"],
>       "parameters": [{
>         "$ref": "../parameters.json#/cityidPathParam"
>@@ -157,7 +157,7 @@
>     },
>     "put": {
>       "x-mojo-to": "Cities#update",
>-      "operationId": "update",
>+      "operationId": "updateCity",
>       "tags": ["cities"],
>       "parameters": [{
>         "$ref": "../parameters.json#/cityidPathParam"
>@@ -219,7 +219,7 @@
>     },
>     "delete": {
>       "x-mojo-to": "Cities#delete",
>-      "operationId": "delete",
>+      "operationId": "deleteCity",
>       "tags": ["cities"],
>       "parameters": [{
>         "$ref": "../parameters.json#/cityidPathParam"
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 15486: 65128 | 65129 | 65130 | 65131 | 65132 | 65133 | 67202 | 67203 | 67204 | 67205 | 67206 | 67207 | 67337 | 67840 | 67841 | 67842 | 67843 | 67844 | 67845 | 68728 | 68729 | 68730 | 68731 | 68732 | 68733 | 68734 | 68735 | 68750 | 68751 | 68752 | 68791 | 71314 | 71315 | 71316 | 71317 | 71318 | 71319 | 72709 | 79318 | 79319 | 79320 | 79321 | 79322 | 79323 | 79324 | 79696 | 79697 | 79698 | 79699 | 79700 | 79701 | 79702 | 80478 | 80479 | 80480 | 80481 | 80482 | 80483 | 80484 | 81087