Bugzilla – Attachment 688 Details for
Bug 2505
Omnibus: Enable Perl warnings in all modules and scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for opac-addbybiblionumber.pl and opac-alert-suscribe.pl
0006-Bug-2505-Enabled-warnings-in-opac-addbybiblionumber.patch (text/plain), 1.62 KB, created by
Chris Cormack
on 2009-08-09 21:32:00 UTC
(
hide
)
Description:
Patch for opac-addbybiblionumber.pl and opac-alert-suscribe.pl
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2009-08-09 21:32:00 UTC
Size:
1.62 KB
patch
obsolete
>From f0f3cad8a5b1eeaf63fa298e5416a372942e0555 Mon Sep 17 00:00:00 2001 >From: Garry Collum <gcollum@gmail.com> >Date: Sun, 9 Aug 2009 17:35:04 -0400 >Subject: [PATCH] Bug 2505: Enabled warnings in opac-addbybiblionumber.pl and opac-alert-subscribe.pl >Content-Type: text/plain; charset="utf-8" > >Enabled warnings and fixed unintialized variables in opac-alert-subscribe.pl >--- > opac/opac-addbybiblionumber.pl | 2 ++ > opac/opac-alert-subscribe.pl | 6 ++++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-addbybiblionumber.pl b/opac/opac-addbybiblionumber.pl >index 9e67b12..cb3a372 100755 >--- a/opac/opac-addbybiblionumber.pl >+++ b/opac/opac-addbybiblionumber.pl >@@ -23,6 +23,8 @@ > # Suite 330, Boston, MA 02111-1307 USA > > use strict; >+use warnings; >+ > use C4::Biblio; > use CGI; > use C4::VirtualShelves qw/:DEFAULT GetRecentShelves RefreshShelvesSummary/; >diff --git a/opac/opac-alert-subscribe.pl b/opac/opac-alert-subscribe.pl >index d0b68b1..8e827b6 100755 >--- a/opac/opac-alert-subscribe.pl >+++ b/opac/opac-alert-subscribe.pl >@@ -19,6 +19,8 @@ > > > use strict; >+use warnings; >+ > use CGI; > use C4::Auth; > use C4::Dates; >@@ -30,13 +32,13 @@ use C4::Serials; > > > my $query = new CGI; >-my $op = $query->param('op'); >+my $op = $query->param('op') || ''; > my $dbh = C4::Context->dbh; > > my $sth; > my ( $template, $loggedinuser, $cookie ); > my $externalid = $query->param('externalid'); >-my $alerttype = $query->param('alerttype'); >+my $alerttype = $query->param('alerttype') || ''; > my $biblionumber = $query->param('biblionumber'); > > ( $template, $loggedinuser, $cookie ) = get_template_and_user( >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2505
:
686
|
687
|
688
|
689
|
690
|
691
|
692
|
693
|
694
|
695
|
696
|
697
|
698
|
699
|
700
|
701
|
702
|
703
|
704
|
705
|
706
|
707
|
708
|
709
|
2223
|
3884
|
4574
|
8209
|
8317
|
8322
|
8373
|
9034
|
9035
|
9036
|
34442