Attachment 68827 Details for Bug 19182 – Bug 19182: Change to use ENV, fix login and passwords

[patch] Bug 19182: Change to use ENV, fix login and passwords

Bug-19182-Change-to-use-ENV-fix-login-and-password.patch (text/plain), 2.29 KB, created by Mark Tompsett on 2017-10-30 03:42:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2017-10-30 03:42:30 UTC

Size: 2.29 KB

patch

obsolete

>From 21ad61ba99859b92c37ffcfdac687647e2ee428f Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Mon, 30 Oct 2017 03:39:40 +0000
>Subject: [PATCH] Bug 19182: Change to use ENV, fix login and passwords
>
>The kohadevbox has admin/admin set, so for testing when
>creating the initial superuser, if you wish to minimize
>effort, use admin/admin. Otherwise, make sure to:
>export KOHA_USER={whatever your user is}
>export KOHA_PASS={whatever your password is}
>before attempting to run the test.
>
>Also, this test was failing because of a validation check on
>the passwords requiring uppercase letters, lowercase letters,
>and numbers. Changed the sample data passwords to fix.
>---
> t/db_dependent/selenium/itemsearch.t | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
>diff --git a/t/db_dependent/selenium/itemsearch.t b/t/db_dependent/selenium/itemsearch.t
>index 56cbfaa..5557278 100644
>--- a/t/db_dependent/selenium/itemsearch.t
>+++ b/t/db_dependent/selenium/itemsearch.t
>@@ -34,10 +34,12 @@ use MARC::Record;
> use MARC::Field;
> 
> my $dbh = C4::Context->dbh;
>-my $login = 'koha';
>-my $password = 'koha';
>-my $base_url= 'http://'.C4::Context->preference("staffClientBaseURL")."/cgi-bin/koha/";
>-my $opac_url= C4::Context->preference("OPACBaseURL");
>+my $login = $ENV{KOHA_USER} || 'koha';
>+my $password = $ENV{KOHA_PASS} || 'koha';
>+my $staff_client_base_url =
>+    $ENV{KOHA_INTRANET_URL} || C4::Context->preference("staffClientBaseUrl") || q{};
>+my $base_url= $staff_client_base_url . "/cgi-bin/koha/";
>+my $opac_url = $ENV{KOHA_OPAC_URL} || C4::Context->preference("OPACBaseURL") || q{};
> 
> my $number_of_biblios_to_insert = 3;
> our $sample_data = {
>@@ -51,8 +53,8 @@ our $sample_data = {
>         surname    => 'test_patron_surname',
>         cardnumber => '4242424242',
>         userid     => 'test_username',
>-        password   => 'password',
>-        password2  => 'password'
>+        password   => 'Password123',
>+        password2  => 'Password123'
>     },
> };
> 
>@@ -180,7 +182,7 @@ END {
> 
> sub auth {
>     my ( $driver, $login, $password) = @_;
>-    fill_form( $driver, { userid => 'koha', password => 'koha' } );
>+    fill_form( $driver, { userid => $login, password => $password } );
>     my $login_button = $driver->find_element('//input[@id="submit"]');
>     $login_button->submit();
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19182: 66503 | 66504 | 68826 | 68827