Bugzilla – Attachment 68831 Details for
Bug 19189
Reserving and renewing item in OPAC selenium test
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19189: Change to use ENV, fix login and passwords
Bug-19189-Change-to-use-ENV-fix-login-and-password.patch (text/plain), 2.33 KB, created by
Mark Tompsett
on 2017-10-30 04:35:38 UTC
(
hide
)
Description:
Bug 19189: Change to use ENV, fix login and passwords
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-10-30 04:35:38 UTC
Size:
2.33 KB
patch
obsolete
>From ed6646f8429d5648085ad448c1e3a035e49bf12b Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 30 Oct 2017 04:34:10 +0000 >Subject: [PATCH] Bug 19189: Change to use ENV, fix login and passwords > >The kohadevbox has admin/admin set, so for testing when >creating the initial superuser, if you wish to minimize >effort, use admin/admin. Otherwise, make sure to: >export KOHA_USER={whatever your user is} >export KOHA_PASS={whatever your password is} >before attempting to run the test. > >Also, this test was failing because of a validation check on >the passwords requiring uppercase letters, lowercase letters, >and numbers. Changed the sample data passwords to fix. >--- > t/db_dependent/selenium/opac_reserveitem.t | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/selenium/opac_reserveitem.t b/t/db_dependent/selenium/opac_reserveitem.t >index a763247..0db943c 100644 >--- a/t/db_dependent/selenium/opac_reserveitem.t >+++ b/t/db_dependent/selenium/opac_reserveitem.t >@@ -32,10 +32,12 @@ use MARC::Record; > use MARC::Field; > > my $dbh = C4::Context->dbh; >-my $login = 'koha'; >-my $password = 'koha'; >-my $base_url= 'http://'.C4::Context->preference("staffClientBaseURL")."/cgi-bin/koha/"; >-my $opac_url= C4::Context->preference("OPACBaseURL"); >+my $login = $ENV{KOHA_USER} || 'koha_kohadev'; >+my $password = $ENV{KOHA_PASS} || 'password'; >+my $staff_client_base_url = >+ $ENV{KOHA_INTRANET_URL} || C4::Context->preference("staffClientBaseUrl") || q{}; >+my $base_url= $staff_client_base_url . "/cgi-bin/koha/"; >+my $opac_url = $ENV{KOHA_OPAC_URL} || C4::Context->preference("OPACBaseURL") || q{}; > > my $number_of_biblios_to_insert = 3; > our $sample_data = { >@@ -49,8 +51,8 @@ our $sample_data = { > surname => 'test_patron_surname', > cardnumber => '4242424242', > userid => 'test_username', >- password => 'password', >- password2 => 'password' >+ password => 'Password123', >+ password2 => 'Password123' > }, > }; > >@@ -162,7 +164,7 @@ END { > > sub auth { > my ( $driver, $login, $password) = @_; >- fill_form( $driver, { userid => 'koha', password => 'koha' } ); >+ fill_form( $driver, { userid => $login, password => $password } ); > my $login_button = $driver->find_element('//input[@id="submit"]'); > $login_button->submit(); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19189
:
66513
| 68831