Attachment 68842 Details for Bug 17989 – Bug 17989: Final changes

[patch] Bug 17989: Final changes

Bug-17989-Final-changes.patch (text/plain), 1.52 KB, created by Marcel de Rooy on 2017-10-30 10:44:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-10-30 10:44:27 UTC

Size: 1.52 KB

patch

obsolete

>From bd6b96ace0100517bf183ddffa589ddc2cef38d2 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 25 Jan 2017 15:32:01 +0100
>Subject: [PATCH] Bug 17989: Final changes
>Content-Type: text/plain; charset=utf-8
>
>[1] The template sco/printslip.tt is in the regular modules directory.
>Should not be prefixed with a slash.
>
>Test plan:
>[1] Try to find another occurrence just like the one corrected in
>    sco/printslip.pl where an absolute path is passed to gettemplate or
>    get_template_and_user. I already tried several regex variations
>    while git grepping template_name, but you may still find one..
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Amended: Removed the changes for svc/members/search. Not needed.
>Commit message adjusted accordingly.
>---
> opac/sco/printslip.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/sco/printslip.pl b/opac/sco/printslip.pl
>index b85b8f5..e94077d 100755
>--- a/opac/sco/printslip.pl
>+++ b/opac/sco/printslip.pl
>@@ -45,7 +45,7 @@ my $error = $input->param('error');
> # patrons still need to be able to print receipts
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {
>-        template_name   => "/sco/printslip.tt",
>+        template_name   => "sco/printslip.tt",
>         query           => $input,
>         type            => "opac",
>     }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17989: 65277 | 65278 | 65279 | 65280 | 65281 | 66272 | 66273 | 66274 | 66275 | 66276 | 66317 | 66318 | 66319 | 66320 | 66321 | 67514 | 67515 | 67516 | 67517 | 67518 | 68654 | 68667 | 68668 | 68669 | 68670 | 68671 | 68672 | 68842 | 68843