Attachment 68857 Details for Bug 19551 – Bug 19551 - Fix wrong order of operations iun cash register report

[patch] Bug 19551 - Fix wrong order of operations iun cash register report

Bug-19551---Fix-wrong-order-of-operations-iun-cash.patch (text/plain), 1.31 KB, created by Nick Clemens (kidclamp) on 2017-10-31 13:20:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-10-31 13:20:17 UTC

Size: 1.31 KB

patch

obsolete

>From 248d2022be7c387e59dd6d570c0863dadf85bf7c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 31 Oct 2017 13:17:26 +0000
>Subject: [PATCH] Bug 19551 - Fix wrong order of operations iun cash register
> report
>
>To test:
>1 - Find or create a fine for a patron
>2 - Write it off
>3 - Run the cash register report for current date, see your write off
>4 - Run the cash register report for previous dates, still see your
>write off
>5 - Apply patch
>6 - Run cash register for current date, writee off shows (good)
>7 - Run cash register report for previous dates, write off does not show
>(good)
>8 - Sign off
>---
> reports/cash_register_stats.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl
>index 158625d..0a1ff54 100755
>--- a/reports/cash_register_stats.pl
>+++ b/reports/cash_register_stats.pl
>@@ -75,7 +75,7 @@ if ($do_it) {
>         $whereTType = q{ AND accounttype IN ('Pay','C') };
>     } else { #Single transac type
>         if ($transaction_type eq 'FORW') {
>-            $whereTType = q{ AND accounttype = 'FOR' OR accounttype = 'W' };
>+            $whereTType = q{ AND accounttype IN ('FOR','W') };
>         } else {
>             $whereTType = q{ AND accounttype = ? };
>             push @extra_params, $transaction_type;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19551: 68857 | 68876 | 69371