Attachment 68892 Details for Bug 19564 – Bug 19564: Fix extraction of sort order from sort condition name

[patch] Bug 19564: Fix extraction of sort order from sort condition name

Bug-19564-Fix-extraction-of-sort-order-from-sort-c.patch (text/plain), 1.11 KB, created by David Gustafsson on 2017-11-02 14:07:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Gustafsson

Created: 2017-11-02 14:07:05 UTC

Size: 1.11 KB

patch

obsolete

>From 2bc177c16d9cc751a753e82ae0c005836ccac52e Mon Sep 17 00:00:00 2001
>From: David Gustafsson <david.gustafsson@ub.gu.se>
>Date: Thu, 2 Nov 2017 15:02:23 +0100
>Subject: [PATCH] Bug 19564: Fix extraction of sort order from sort condition
> name
>
>Currently sort order is extracted from sort condition by splitting the
>field, instead use regular expression to extract the last part preceded
>by underscore.
>---
> Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>index 1c741d35f3..9cfc35389e 100644
>--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>@@ -620,7 +620,7 @@ sub _convert_index_fields {
>     # when joining things, to indicate we make it an 'OR' join.
>     # (Sorry, this got a bit ugly after special cases were found.)
>     grep { $_->{field} } map {
>-        my ( $f, $t ) = split /,/;
>+        my ( $f, $d ) = /(.+)_(.+)/;
>         my $mc = '';
>         if ($f =~ /^mc-/) {
>             $mc = 'mc-';
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 19564: 68892 | 68998 | 70137 | 73022 | 73023 | 73385 | 73386 | 73387