Attachment 69018 Details for Bug 19584 – Bug 19584: Check compare barcodes box when uploading barcodes

[patch] Bug 19584: Check compare barcodes box when uploading barcodes

Bug-19584-Check-compare-barcodes-box-when-uploadin.patch (text/plain), 2.44 KB, created by Marcel de Rooy on 2017-11-08 13:12:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-11-08 13:12:33 UTC

Size: 2.44 KB

patch

obsolete

>From f79ad31fac565f9238179ba4f20e3df1a81527f1 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 7 Nov 2017 15:29:56 +0100
>Subject: [PATCH] Bug 19584: Check compare barcodes box when uploading barcodes
>Content-Type: text/plain; charset=utf-8
>
>This patch makes two trivial changes in the inventory interface:
>
>[1] If you have uploaded a barcode file, the compare barcodes checkbox is
>automatically checked. In most cases this will be the option the user wants.
>The compare will report missed items on the shelf.
>[2] If the compare barcodes checkbox is checked, the Skip items on loan-
>checkbox is automatically checked. This again is often desirable. If you
>compare, you normally are not interested in seeing items reported missing
>while they are checked out.
>
>Test plan:
>[1] Upload a barcode file on inventory. Is the compare checked?
>[2] Toggle compare. Does 'skip items on loan' change accordingly?
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>index 93ca911..6659894 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
>@@ -102,10 +102,13 @@ $(document).ready(function(){
>         if( $("#uploadbarcodes").val() ) {
>             $("#setdate").prop('disabled',false);
>             $("#compareinv2barcd").prop('disabled',false);
>+            $("#compareinv2barcd").attr('checked',true); // default
>             $("#dont_checkin").prop('disabled',false);
>             if( $("#compareinv2barcd").attr('checked') ) {
>                 $("fieldset#optionalfilters").show();
>+                $("#ignoreissued").attr('checked',true); // default
>             } else {
>+                $("#ignoreissued").attr('checked',false);
>                 $("fieldset#optionalfilters").hide();
>             }
>         } else {
>@@ -120,7 +123,9 @@ $(document).ready(function(){
>     $("#compareinv2barcd").click(function() {
>         if( $("#compareinv2barcd").attr('checked') ) {
>             $("fieldset#optionalfilters").show();
>+            $("#ignoreissued").attr('checked',true); // default
>         } else {
>+            $("#ignoreissued").attr('checked',false);
>             $("fieldset#optionalfilters").hide();
>         }
>     });
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19584: 68997 | 69017 | 69018 | 69739 | 70531 | 71656 | 71657 | 73255 | 73256