Bugzilla – Attachment 69046 Details for
Bug 7317
Add an Interlibrary Loan Module to Circulation and OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7317: Remove traces of UnmediatedILL
Bug-7317-Remove-traces-of-UnmediatedILL.patch (text/plain), 2.27 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-11-08 19:39:16 UTC
(
hide
)
Description:
Bug 7317: Remove traces of UnmediatedILL
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-11-08 19:39:16 UTC
Size:
2.27 KB
patch
obsolete
>From 8ef4f1a6a02065c12e0005a6cbaa315f047df9b4 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 8 Nov 2017 16:37:52 -0300 >Subject: [PATCH] Bug 7317: Remove traces of UnmediatedILL > >This patch removes references to UnmediatedILL. This feature is introduced on >a separate bug. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Illrequest/Config.pm | 8 ++------ > t/db_dependent/Illrequest/Config.t | 2 -- > 2 files changed, 2 insertions(+), 8 deletions(-) > >diff --git a/Koha/Illrequest/Config.pm b/Koha/Illrequest/Config.pm >index 776cb99f33..28e80ce0f6 100644 >--- a/Koha/Illrequest/Config.pm >+++ b/Koha/Illrequest/Config.pm >@@ -64,8 +64,7 @@ sub new { > my $self = {}; > > $self->{configuration} = _load_configuration( >- C4::Context->config("interlibrary_loans"), >- C4::Context->preference("UnmediatedILL") >+ C4::Context->config("interlibrary_loans") > ); > > bless $self, $class; >@@ -230,7 +229,7 @@ file to ensure we have only valid input there. > =cut > > sub _load_configuration { >- my ( $xml_config, $unmediated ) = @_; >+ my ( $xml_config ) = @_; > my $xml_backend_dir = $xml_config->{backend_directory}; > > # Default data structure to be returned >@@ -309,9 +308,6 @@ sub _load_configuration { > # ILL Partners > $configuration->{partner_code} = $xml_config->{partner_code} || 'ILLLIBS'; > >- die "No DEFAULT_FORMATS has been defined in koha-conf.xml, but UNMEDIATEDILL is active." >- if ( $unmediated && !$configuration->{default_formats}->{default} ); >- > return $configuration; > } > >diff --git a/t/db_dependent/Illrequest/Config.t b/t/db_dependent/Illrequest/Config.t >index f44fa85cfd..3f26c6b855 100644 >--- a/t/db_dependent/Illrequest/Config.t >+++ b/t/db_dependent/Illrequest/Config.t >@@ -43,7 +43,6 @@ subtest 'Basics' => sub { > > $schema->storage->txn_begin; > >- t::lib::Mocks::mock_preference("UnmediatedILL", 0); > t::lib::Mocks::mock_config("interlibrary_loans", {}); > > my $config = Koha::Illrequest::Config->new; >@@ -415,7 +414,6 @@ subtest 'Final tests' => sub { > > $schema->storage->txn_begin; > >- t::lib::Mocks::mock_preference("UnmediatedILL", 0); > t::lib::Mocks::mock_config("interlibrary_loans", {}); > > my $config = Koha::Illrequest::Config->new; >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7317
:
59893
|
59894
|
59895
|
59920
|
60485
|
60486
|
60487
|
60488
|
63081
|
63082
|
63083
|
63084
|
63085
|
63086
|
63087
|
63088
|
63089
|
63090
|
63113
|
63175
|
63176
|
63354
|
63421
|
63472
|
63475
|
65469
|
65470
|
65471
|
65472
|
65473
|
65474
|
65475
|
65476
|
66266
|
67242
|
67243
|
67244
|
67245
|
67246
|
67247
|
67248
|
67249
|
67250
|
67251
|
67252
|
67253
|
67254
|
67255
|
67256
|
67257
|
67258
|
67259
|
67260
|
67261
|
67262
|
67263
|
67264
|
67281
|
67282
|
67283
|
67284
|
67285
|
67286
|
67287
|
67288
|
67289
|
67290
|
67291
|
67292
|
67293
|
67294
|
67295
|
67296
|
67297
|
67298
|
67299
|
67300
|
67301
|
67302
|
67303
|
68185
|
68186
|
68328
|
68391
|
68406
|
68407
|
68408
|
68409
|
68418
|
68444
|
68445
|
68483
|
68484
|
68485
|
68487
|
68516
|
68517
|
68518
|
68519
|
68520
|
68521
|
68522
|
68523
|
68524
|
68525
|
68542
|
68543
|
68544
|
68545
|
68546
|
68547
|
68548
|
68549
|
68550
|
68551
|
68552
|
68558
|
68559
|
68560
|
68561
|
68562
|
68563
|
68564
|
68565
|
68566
|
68567
|
68858
|
68874
|
68877
|
68878
|
68885
|
68886
|
68921
|
68922
|
68926
|
68927
|
68928
|
68929
|
68931
|
68932
|
68933
|
68988
|
68989
|
68999
|
69000
|
69006
|
69008
|
69009
|
69012
|
69014
|
69044
|
69045
| 69046 |
69056
|
69059
|
69060
|
69061
|
69063
|
69064
|
69065
|
69066
|
69069
|
69070
|
69071
|
69074