Bugzilla – Attachment 6905 Details for
Bug 6098
zebra conf NSB NSE indexed as space
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6098 Followup -- doesn't replace NSB/NSE by space
Bug-6098-Followup----doesnt-replace-NSBNSE-by-spac.patch (text/plain), 1.63 KB, created by
Chris Cormack
on 2011-12-21 19:16:57 UTC
(
hide
)
Description:
Bug 6098 Followup -- doesn't replace NSB/NSE by space
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2011-12-21 19:16:57 UTC
Size:
1.63 KB
patch
obsolete
>From 8b0eeb2f0016245653a272ea72ed9ea943a41c5d Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Fri, 13 May 2011 15:24:39 +0200 >Subject: [PATCH] Bug 6098 Followup -- doesn't replace NSB/NSE by space >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >On any page, NSB/NSE characters are replaced by space in Output.pm. It isn't a >good thing: > > - It isn't necessary since Zebra indexer handle properly those characters as > delimiter. > - It isn't necessary for display since XSL file already do that. > - It isn't efficient since a regex is done on every whole page sent by Koha, > not only on biblio record part. > - It removes an information that librarian want to keep in their biblio > records: any record edited in Koha loose its NSB/NSE characters. > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > C4/Output.pm | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > >diff --git a/C4/Output.pm b/C4/Output.pm >index 6ab16d9..75ced46 100644 >--- a/C4/Output.pm >+++ b/C4/Output.pm >@@ -291,10 +291,7 @@ sub output_with_http_headers($$$$;$) { > $options->{'Content-Style-Type' } = 'text/css'; > $options->{'Content-Script-Type'} = 'text/javascript'; > } >- # remove SUDOC specific NSB NSE >- $data =~ s/\x{C2}\x{98}|\x{C2}\x{9C}/ /g; >- $data =~ s/\x{C2}\x{88}|\x{C2}\x{89}/ /g; >- >+ > # We can't encode here, that will double encode our templates, and xslt > # We need to fix the encoding as it comes out of the database, or when we pass the variables to templates > >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6098
:
3758
|
4105
|
6904
| 6905