Attachment 69209 Details for Bug 19514 – Bug 19514: Add client-side check

[patch] Bug 19514: Add client-side check

Bug-19514-Add-client-side-check.patch (text/plain), 3.17 KB, created by David Bourgault on 2017-11-17 21:21:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Bourgault

Created: 2017-11-17 21:21:33 UTC

Size: 3.17 KB

patch

obsolete

>From 3870913a0fb87622e4767f3097558d1dff16831b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 6 Nov 2017 12:22:59 -0300
>Subject: [PATCH] Bug 19514: Add client-side check
>
>Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
>---
> C4/InstallAuth.pm                                      |  4 ++++
> .../prog/en/modules/onboarding/onboardingstep3.tt      |  3 +++
> koha-tmpl/intranet-tmpl/prog/js/onboarding.js          | 18 ++++++++++++++++++
> 3 files changed, 25 insertions(+)
>
>diff --git a/C4/InstallAuth.pm b/C4/InstallAuth.pm
>index 9c6795f..6204f11 100644
>--- a/C4/InstallAuth.pm
>+++ b/C4/InstallAuth.pm
>@@ -149,6 +149,10 @@ sub get_template_and_user {
>             $template->param( CAN_user_serials          => 1 );
>             $template->param( CAN_user_reports          => 1 );
>         }
>+
>+        my $minPasswordLength = C4::Context->preference('minPasswordLength');
>+        $minPasswordLength = 3 if not $minPasswordLength or $minPasswordLength < 3;
>+        $template->param(minPasswordLength => $minPasswordLength,);
>     }
>     return ( $template, $borrowernumber, $cookie );
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
>index 67a8c9b..a812b08 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
>@@ -1,3 +1,4 @@
>+[% USE Koha %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Web installer &rsaquo; Create Koha administrator patron</title>
> [% INCLUDE 'installer-doc-head-close.inc' %]
>@@ -112,3 +113,5 @@
>         </div> 
> 
> [% INCLUDE 'intranet-bottom.inc' %]
>+[% PROCESS 'password_check.inc' %]
>+[% PROCESS 'add_password_check' new_password => 'password' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/onboarding.js b/koha-tmpl/intranet-tmpl/prog/js/onboarding.js
>index 4816dfd..93cb010 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/onboarding.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/onboarding.js
>@@ -1,5 +1,17 @@
> function _(s) { return s; } // dummy function for gettext
> 
>+// http://stackoverflow.com/questions/1038746/equivalent-of-string-format-in-jquery/5341855#5341855
>+String.prototype.format = function() { return formatstr(this, arguments); };
>+function formatstr(str, col) {
>+    col = typeof col === 'object' ? col : Array.prototype.slice.call(arguments, 1);
>+    var idx = 0;
>+    return str.replace(/%%|%s|%(\d+)\$s/g, function (m, n) {
>+        if (m == "%%") { return "%"; }
>+        if (m == "%s") { return col[idx++]; }
>+        return col[n];
>+    });
>+}
>+
> jQuery.validator.addMethod( "category_code_check", function(value,element){
>     var patt = /^[A-Za-z0-9]{0,10}$/g;
>     if (patt.test(element.value)) {
>@@ -114,6 +126,12 @@ $(document).ready(function() {
>                 required: true
>             },
>             password: {
>+                required: true,
>+                password_strong: true,
>+                password_no_spaces: true
>+            },
>+            password2: {
>+                required: true,
>                 password_match: true
>             }
>         },
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 19514: 68386 | 68387 | 68982 | 69208 | 69209 | 69796 | 69797